Repository navigation
feat(sources): Settings > Devices, every sender and how it is read - #102
Merged
Merged
Conversation
The devices that could use a source rule were found by noticing that their messages looked wrong. Settings > Devices lists every address messages arrive from, and marks them. - Engine: sources.Inventory counts what the reader reads as messages arrive - not what is read again or tried: per address, the messages since the engine started and in the last minute, the last heard, the protocol, the hostname and application of the last message and the different hostnames read lately, how many had a header that bends the RFCs, no priority, or no hostname once read, the rule that read the last one, and that last message cut to 400 bytes. Bounded to 5,000 addresses. GetSourceDevices and ClearSourceDevices are on Backend, so the service's inventory is shown when the window drives it. - The tab adds the addresses the history holds (QueryMessageGroups by source), with their counts. A device that bends the RFCs or sends no hostname and that no rule reads is marked, and can be listed alone; the button on each line opens the editor on the rule that reads it, or a new one for its address, tried on its latest live messages or at least its last one. Several hostnames behind one address are counted and explained: a relay, or a device that sends none. - The 8 languages, the user guide (Devices), the README and the documentation page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #101, which is on #100, which is on #99. Each will be retargeted to
mainas the one below it is merged.Today, the devices that could use a source rule are found by noticing that their messages look wrong. Settings › Devices lists every address messages arrive from, and marks those devices.
For the user
How
sources.Inventorycounts what the reader reads as messages arrive (Reader.Read). It does not count what is read again (ReadAt, feat(sources): read stored messages again with the rules #100) or tried in the editor (Try).Backend:GetSourceDevicesandClearSourceDevices. A window driving the service shows the service's inventory, sealing service included, since that service is what receives.QueryMessageGroups(…, "sourceIP").Tests
internal/sources:cuton a character boundary.internal/engine: what the reader reads is listed by address, and clearing works.Checked:
go vet(Windows, Linux),staticcheck,go test -race ./...,svelte-check --fail-on-warnings,npm test,npm run build, the docs' links.