Repository navigation
feat: add stratified whole-database signal scanning - #30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
faers_phv_scan_stratified(), a stratified variant of the whole-databasescanner: it splits the database into strata defined by categorical
democolumns (
sex,age_grp,occp_cod, ...) and builds one 2x2 contingencytable per
stratum x drug x eventcombination against the stratum-internalbackground (
n_stratum).Details
"Missing"stratum bydefault (
.na_stratum = "keep"), or excluded with"drop"; a warning isissued when a stratification column is missing for >30% of reports.
.min_aapplies per stratum; strata columns must be categorical(character/VARCHAR) demo columns so both backends produce identical output.
(reports are atomic per stratum, so chunk counts stay exact).
query with a
strataCTE (CASE ... 'Missing'coalescing /WHEREfordrop mode).
scan.R/scan-db.Rcode paths.Tests
tests/testthat/test_scan-strata.R: 94 assertions covering per-stratum2x2 correctness vs direct computation, keep/drop semantics, cross-strata,
per-stratum
.min_a, chunked vs unchunked identity, and memory-vs-duckdbidentical()parity (pt / soc_name / hlgt_name).(env-only items unchanged).