Skip to content

add future attribute to dns requests - #169

Merged
Vizonex merged 2 commits into
mainfrom
fut-dns-attr-fix
Oct 2, 2026
Merged

Vizonex merged 2 commits into
mainfrom
fut-dns-attr-fix

Conversation

@Vizonex

@Vizonex Vizonex commented Oct 1, 2026

Copy link
Copy Markdown
Owner

What do these changes do?

This PR Fixes #168 and the bandage bottleneck witnessed earlier. It will help optimize when ctypedef callbacks are applied.

Are there changes in behavior for the user?

Is it a substantial burden for the maintainers to support this?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@Vizonex

Vizonex commented Oct 1, 2026 •

Copy link
Copy Markdown
Owner Author

I'll be back later this evening or tomorrow to explore other ideas on how we can safely get around this reference bug. My Second idea was subclassing winloop.loop.Future and then using it to hold the NameInfoRequest and AddrInfoRequest until they are ready to be called and finished off. That way this annoying problems will stop existing.

cdef class VizonexsMiraclePill(Future): # I will always be funny, you cannot stop me >:)
     cdef:
           NameInfoRequest nir

I think I'll coin them NameInfoFuture and AddrInfoFuture :)

@Vizonex
Vizonex merged commit b8b66d1 into main Oct 2, 2026
37 of 38 checks passed
@Vizonex
Vizonex deleted the fut-dns-attr-fix branch October 2, 2026 15:10
@Vizonex

Vizonex commented Oct 2, 2026

Copy link
Copy Markdown
Owner Author

Job complete 3.14t has a 50/50 chance but for what it's fault is is unrelated to DNS so I'll let it pass for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant