Use newly compiled winloop.loop.Future objects on DNS related calls - #167
Merged
Merged
Conversation
winloop.loop.Future objects on dns related callswinloop.loop.Future objects on DNS related calls
Owner
Author
|
I'm starting to see 3 minute benchmarks for testruns. This makes me very happy :) Keep in mind these tests used to take around 7-8 minutes on bad days. |
Owner
Author
|
TODO: (Vizonex) Improve 3.14t's lag. (Probably a reference bug of some kind. Improving NameInfo and AdderInfo would change this. I was thinking about trying C Callbacks.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
These changes start whittling down on known bottlenecks between interpreter level and compiled level code.
The less the interpreter is needed the better the outcome.
For now
winloop.Loop.Futureremains internal core component to compete with rsloop's evolving speeds I always encourage friendly competition because it gives me a wakeup call.In a later update like maybe
0.8.0winloop.Loop.Futurewill be exposed at the user-level vialoop.create_futurewhich is my current objective once all internal level code is optimized with this new object.Are there changes in behavior for the user?
DNS Tests take 1.91 seconds instead of 5-7 seconds more than sufficient to not needing c-ares yet.
Is it a substantial burden for the maintainers to support this?
Nope, in fact it does the opposite.
Related issue number
See: #164
Closes #80
Checklist