Repository navigation
sound: configure default plunger audio and remove trough placeholders - #36
Merged
Merged
Conversation
[Low impact] No established defects block merging these prefab changes. SummaryAssigns default plunger sound banks and removes placeholder trough audio.
Reviews (1) · Last reviewed commit: "sound: configure default plunger audio a..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assign the reusable plunger pull and release banks to the default HDRP plunger prefab. Remove placeholder trough sound components so table authors can assign the actual mechanism audio instead of playing duplicate generic events.
Depends on the runtime components in freezy/VisualPinball.Engine#603 and the reusable banks in VisualPinball/VisualPinball.Unity.Assets#4.
Validation: default prefab references checked, the T2 runtime package restored its sound references correctly, and Opus 5.5 reviewed the changes before commit.