Skip to content

Don't report matrix copies of flipper buttons as duplicate inputs - #50

Merged
freezy merged 1 commit into
masterfrom
fix/flipper-mirror-diagnostics
Oct 30, 2026
Merged

freezy merged 1 commit into
masterfrom
fix/flipper-mirror-diagnostics

Conversation

@freezy

@freezy freezy commented Oct 30, 2026

Copy link
Copy Markdown
Member

Pre-Fliptronic WPC definitions list each flipper button twice: as the generic cabinet button and as the matrix switch PinMAME mirrors it into. The converter already gives the input action to the generic button and leaves the matrix copy unmapped, but it also reported a "Duplicate input action" diagnostic for every such copy, so a correct import showed two warnings.

That diagnostic is now skipped when an action has exactly one generic flipper button and one other switch. Anything more ambiguous, such as a second matrix switch with the same flipper role, or two switches both claiming a cabinet action like Start, still produces the diagnostic and leaves the extra switch for manual mapping.

Testing

  • PrefersGenericFlipperButtonsOverMatrixCopies now runs with and without a conflicting third right-flipper switch and checks the diagnostic count (0 and 2). Both cases fail on the previous converter.
  • New ReportsDuplicateCabinetInputActions covers two Start switches.
  • VisualPinball.Engine.PinMAME.Test: 58 passed, 2 skipped (corpus-dependent).

@greptile-apps

greptile-apps Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

The converter stops reporting duplicate-input warnings for one generic flipper button paired with one other switch claiming the same action. The generic button keeps the action; the other switch stays available for manual mapping.

  • Expected flipper-button copies no longer add duplicate warnings.

Reviews (1) · Last reviewed commit: "editor: Don't report matrix copies of fl..." · Reviewed by Greptile

@freezy
freezy merged commit f08499c into master Oct 30, 2026
17 checks passed
@freezy
freezy deleted the fix/flipper-mirror-diagnostics branch October 30, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant