Repository navigation
Keep PinMAME playback preferences owned by the player - #48
Merged
Merged
Conversation
[Medium impact] The reviewed changes appear safe to merge. SummaryExposes effective PinMAME playback gain while keeping shared PCM frames unscaled.
No actionable issues were established in the changes since the previous review. No previous review threads were supplied. Reviews (2) · Last reviewed commit: "pinmame: exclude authoring audio prefere..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PinMAME's authoring mute toggle was serialized into .vpe tables, allowing an editor preview setting to suppress ROM playback in the player. Export now includes only machine/ROM identity, mechanics configuration and solenoid delay. The Unity component keeps its mute toggle for direct play, older package mute keys are ignored, and output gain remains runtime-only. Export leaves the author's preview settings unchanged, while importing into an existing component preserves its local playback preferences.
The central PCM path gets effective playback gain through a cached audio-source adapter: zero when direct-play audio is disabled, otherwise the integration output gain. Subscription and exclusive playback ownership continue through the existing synchronized source, raw PCM stays unscaled, and returning to local playback resets the gain ramp to the current setting.
Validation:
Uses the companion core PCM contract and renderer. Reference playback remains the default.