Skip to content

DmdDevice.ini import, PAC fallback and pause menu status - #5

Merged
freezy merged 2 commits into
masterfrom
feat/render-settings
Oct 18, 2026
Merged

freezy merged 2 commits into
masterfrom
feat/render-settings

Conversation

@freezy

@freezy freezy commented Oct 18, 2026

Copy link
Copy Markdown
Member
  • DmdDevice.ini is found like DmdDevice finds it (DMDDEVICE_CONFIG, VPM_HOME, VPinMAME's COM registration, next to the ROM folder) and fills every setting the user hasn't saved in VPE, including the PAC key.
  • Automatic selection loads the game's .pac whatever its name when there's a key, and otherwise shows the plain tint instead of falling back to a palette-only pin2dmd.pal (which made monochrome DMDs pale yellow).
  • The DMD describes its colorization, tint, imported ini and outputs in the Player's pause menu.

Commits

  • 241850a dmd: Apply DmdDevice.ini automatically, load a game's PAC whatever its name, and describe the DMD in the pause menu.

Part of the render settings work across repos (all on feat/render-settings): VisualPinball.Engine, VisualPinball.Unity.Hdrp, VisualPinball.Engine.Player, VisualPinball.Engine.Player.Hdrp, VisualPinball.Engine.PinUp, VisualPinball.Engine.B2sBackglass, VisualPinball.Engine.PinMAME, VisualPinball.Engine.DMD, VisualPinball.Unity.Project.Hdrp and vpe-terminator2.

…s name, and describe the DMD in the pause menu.

DmdDevice.ini is found like DmdDevice finds it (DMDDEVICE_CONFIG, VPM_HOME, VPinMAME's COM registration, next to the ROM folder) and fills every setting the user hasn't saved in VPE, including the PAC key. Automatic selection loads the newest .pac in the game folder with a key and, like DmdDevice, shows the plain tint without one instead of falling back to pin2dmd.pal.
@greptile-apps

greptile-apps Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; all previous findings are addressed and no new actionable issues were found.

Summary

The PR adds automatic DmdDevice.ini settings, updates PAC selection, and describes DMD settings in the pause menu.

  • DmdDevice.ini fills in DMD settings you have not saved in VPE.
  • Automatic colorization picks the newest game-folder PAC when a key is available.
  • The Player’s pause menu shows what the DMD is using.

All three previous findings are addressed. No new actionable issues were found.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Default settings] --> B[Apply DmdDevice.ini]
  B --> C[Keep saved user settings]
  C --> D[Resolve colorization library]
  D --> E[Select and stage colorization]
  E --> F[Create DMD pipeline]
  F --> G[Report loaded colorization and outputs]
  H[Settings picker and validation] --> D
Loading

Reviews (2) · Last reviewed commit: "dmd: Resolve the colorization library li..." · Reviewed by Greptile

…rted colorize = true turn colorization back on, and wait for the DMD before showing it as active.
@freezy
freezy merged commit 9f9d862 into master Oct 18, 2026
5 checks passed
@freezy
freezy deleted the feat/render-settings branch October 18, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant