Repository navigation
DmdDevice.ini import, PAC fallback and pause menu status - #5
Merged
Merged
Conversation
…s name, and describe the DMD in the pause menu. DmdDevice.ini is found like DmdDevice finds it (DMDDEVICE_CONFIG, VPM_HOME, VPinMAME's COM registration, next to the ROM folder) and fills every setting the user hasn't saved in VPE, including the PAC key. Automatic selection loads the newest .pac in the game folder with a key and, like DmdDevice, shows the plain tint without one instead of falling back to pin2dmd.pal.
[Medium impact] The PR appears safe to merge; all previous findings are addressed and no new actionable issues were found. SummaryThe PR adds automatic
All three previous findings are addressed. No new actionable issues were found.
|
…rted colorize = true turn colorization back on, and wait for the DMD before showing it as active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits
Part of the render settings work across repos (all on
feat/render-settings): VisualPinball.Engine, VisualPinball.Unity.Hdrp, VisualPinball.Engine.Player, VisualPinball.Engine.Player.Hdrp, VisualPinball.Engine.PinUp, VisualPinball.Engine.B2sBackglass, VisualPinball.Engine.PinMAME, VisualPinball.Engine.DMD, VisualPinball.Unity.Project.Hdrp and vpe-terminator2.