Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
rejojer
force-pushed
the
feat/list-documents-recursive
branch
from
September 17, 2026 10:45
b00c403 to
31691cd
Compare
Listing a folder returned only its direct contents, with no way to reach the documents in its sub-folders; the endpoint has taken recursive all along, the SDK just never sent it. Listed documents also carry a folder path, served by the cloud. Local mode accepts the flag and ignores it — there are no folders to descend into — and reports the same keys a cloud listing has, path among them, always None.
rejojer
force-pushed
the
feat/list-documents-recursive
branch
from
September 17, 2026 10:49
31691cd to
9cdab7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
list_documents(folder_id=…)returned only that folder's directcontents. There was no way to reach the documents in its sub-folders —
you had to walk the tree yourself, one call per folder.
The endpoint has taken
recursiveall along. The SDK just never sentit.
Change
Verified against a real nested folder on production: 0 documents
without the flag (they all sit in a sub-folder), 19 with it.
Listed documents also carry
path— the folder chain,"Parent/Child"— served by the cloud(VectifyAI/pageindex-compute#644), so this SDK stays a pass-through and
does not join
/folders/back in.pathneeds that PR deployed;recursiveitself works today.Local mode accepts the flag and ignores it — there are no folders to
descend into — and reports the same keys a cloud listing has,
pathamong them, always None.
Tests
The flag reaches the query string only when asked for, so the default
request is unchanged; a local listing carries the same keys. 638 passed.
CI
The two red legs are
test_live_*_citation_prompt*, which fail the sameway on a clean
main: the cloud no longer serves thefootnoteformat.Unrelated to this branch, and already fixed on the branch that drops
that format from the SDK.