Skip to content

publish a wheel - #1251

Merged
LarsAsplund merged 1 commit into
VUnit:masterfrom
dimbleby:publish-wheel
Nov 6, 2026
Merged

LarsAsplund merged 1 commit into
VUnit:masterfrom
dimbleby:publish-wheel

Conversation

@dimbleby

@dimbleby dimbleby commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

build and publish a wheel, as well as a source distribution.

@ru551n

ru551n commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Duplicate of #1214.

@LarsAsplund , I think we should do this change.

@dimbleby

dimbleby commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor Author

Duplicate of #1214.

thanks, I did not spot the other. Comparing the two:

  • best practice is to publish both wheel and sdist
  • I think you do still need to install setuptools during the workflow, for the benefit of release.py validate
  • including py.typed is certainly desirable, you might or might not prefer it to be done separately

@ru551n

ru551n commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Duplicate of #1214.

thanks, I did not spot the other. Comparing the two:

  • best practice is to publish both wheel and sdist
  • I think you do still need to install setuptools during the workflow, for the benefit of release.py validate
  • including py.typed is certainly desirable, you might or might not prefer it to be done separately

Agree. Waiting on @LarsAsplund

@LarsAsplund

Copy link
Copy Markdown
Collaborator

I will approve this change but could you also add a news fragment, see https://vunit.github.io/contributing.html#release-notes-instructions

@dimbleby

dimbleby commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

added news fragment

@LarsAsplund
LarsAsplund merged commit 3fff9e5 into VUnit:master Nov 6, 2026
14 checks passed
@LarsAsplund

Copy link
Copy Markdown
Collaborator

Good, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants