Repository navigation
release: bump revision to 4.4.2 - #290
Merged
Merged
Conversation
Release revision moves +1 per release (owner rule 01.11.2026). The minor is the hardfork number and never changes here; hardfork_version() masks the low 16 bits, so CHAIN_HARDFORK_VERSION stays 4.4.0 and no auto-vote for a fork is triggered.
The emergency-exit wiring suite mutates the literal CHAIN_VERSION line to prove that some test notices a node that does not advertise HF17. With the release revision bumped, the anchor no longer matched and the mutation would have reported 'not applied' instead of exercising the check.
Mainnet config was bumped to 4.4.2, the testnet one stayed at 4.4.1 - two configs
of the same release disagreeing about the release counter. Caught by CI: the
emergency-exit suite mutates the CHAIN_VERSION line in config_testnet.hpp, and
with the anchor updated to 4.4.2 the mutation no longer found its target
('anchor not found -- mutation did not land') - which is exactly what that
guard exists for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release revision +1 for the snapshot export fix merged in #289 (owner rule 01.11.2026: the third field of version(major, hardfork, revision) is the release counter).
Minor is the hardfork number and is untouched:
hardfork_version()masks the low 16 bits, soCHAIN_HARDFORK_VERSIONstays 4.4.0, the assert againsthardfork.d/16.hfholds, and auto-voting for a fork is not triggered.Needed because the image built from master still reports 4.4.1 — the same version as the release already running on the nodes, which makes acceptance unable to tell the two apart.