Repository navigation
Conversation
This commit exists to prove that the tie-break case added in #283 can fail. A green test that has never been seen red is only an assertion that the fixture runs. If tests/consensus_sim/scenarios/test_certified_sibling_switch.cpp is doing its job, 'tie_between_two_siblings_resolves_to_the_smaller_id' must fail on the testnet arms. Do not merge. Close after the run.
Member
Author
|
Мутация поймана. Арм Армы 1v и 2v зелёные не потому, что кейс декоративный: сьют master не тронут. Ветка удалена. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a mutation check, not a change
It flips one comparison in
database::canonical_sibling_id():i.e. when two rivals hold the same number of votes, rank the larger id instead of the smaller one.
Why it exists
#283 added
tie_between_two_siblings_resolves_to_the_smaller_id. That case went green — but a test that has never been seen red is only proof that the fixture runs, not proof that it guards the rule. Eighteen days of consensus work this month were spent on rules that were "obviously covered": the certified-sibling acceptance gate inviz-toolsturned out to be reading the failure line as success, and the convergence counter was blind to the very path it was meant to watch.Expected result
Testnet config + consensus_sim (1|2|4 validators)must fail, and the failing assertion should name the tie case.If those jobs pass, the case is decorative and needs fixing.
Outcome
Close without merging once the run is read.
masteris untouched.