Repository navigation
Conversation
The Sagemcom branch in the OBIS path never ran: meterType is reset to Unknown at the start of that path and is only set from the SAGY system title afterwards. As a result every T210-D reported the meter id "SAGY" (system title with non-ASCII bytes stripped) and no meter timestamp. - Identify Sagemcom from the system title before the meter-specific handling. - Take the meter serial from the last element of the structure instead of the hard-coded index 58, which pointed past the end of the list (the serial is element 57 in gh867-2). - Decode the clock (element 1) through adjustForKnownIssues() like the OBIS clock, and only when it is a 12-byte octet string. gh867-2 with system title SAGY05E894B6: id 178210128502 (was "SAGY"), meter time 2024-11-15 13:45:45 UTC (meter local 14:45:45, deviation -60). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LAhKXXvV3q3Ro13EackZPq
…oder) See the first commit on this branch for the rationale. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LAhKXXvV3q3Ro13EackZPq
🔧 PR Build ArtifactsVersion: All environments built successfully. Download the zip files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Sagemcom branch in the OBIS path never ran.
meterTypeis reset to Unknown at the start of that path and is only set from theSAGYsystem title at the end of the constructor. As a result every T210-D reports the meter id "SAGY" (system title with non-ASCII bytes stripped, identical for all meters) and no meter timestamp.getLastElement()) instead of the hard-coded index 58, which pointed past the end of the list. In gh867-2 the serial is element 57.adjustForKnownIssues()like the OBIS clock, and only if it is a 12-byte octet string.Test:
sagemcom/gh867-2(#867) decoded with system titleSAGY05E894B6: id 178210128502 (was "SAGY"), meter time 2024-11-15 13:45:45 UTC (meter local 14:45:45, deviation −60). Golden master unchanged (the fixture has no system title).Note: per the comment in LNG3.cpp, meterId feeds the MQTT topic and Home Assistant entity, so these may change from "SAGY" to the real serial after upgrade.
(The web editor also added a final newline to IEC6205675.cpp.)
🤖 Generated with Claude Code
https://claude.ai/code/session_01LAhKXXvV3q3Ro13EackZPq