Repository navigation
Accept valid A2 SQL alternatives and improve grading feedback - #484
Open
danielrazavi wants to merge 9 commits into
Open
danielrazavi wants to merge 9 commits into
danielrazavi wants to merge 9 commits into
Conversation
|
Thanks for your contribution! 🎉 Please remember to tag or request a review from the DSI team. Give us up to 72 hours to review your pull request. We appreciate your patience and efforts. |
danielrazavi
marked this pull request as ready for review
October 20, 2026 16:54
Member
Author
|
@khsergvl @niyazmnazari thanks again for the feedback! I've addressed the points you raised and tested the changes in my fork, including renamed/reordered columns and a deliberately wrong answer to check it still gets rejected. The description links each fix and the test results. Could you take a look and review when you have a chance? |
Collaborator
|
@danielrazavi there is a need to make this part abstract: And here: https://github.com/UofT-DSI/sql/blob/main/.github/workflows/sql_assignment_runner.yml#L93 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #481: accept different valid SQL answers without accepting incorrect results.
Fixes
-- querycomments caused errorsBoth A2 versions (DC Cohort and Microcredential Cohort) now remind students to track names used in earlier queries, rather than impose output-name restrictions.
Cleaner feedback: correct answers' SQL/output is collapsed; wrong answers and errors stay expanded. Status/messages always remain visible. bb2e41b
What I Tested
No sample answers or instructor solutions are added to the course repo.