Repository navigation
fix(rest/python): return ready_for_complete only when fulfillment is selected - #254
Merged
damaz91 merged 2 commits intoOct 16, 2026
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
aksharprabhudesai
force-pushed
the
fix/python-ready-for-complete
branch
from
October 14, 2026 08:18
4e87501 to
c4e1fba
Compare
damaz91
approved these changes
Oct 15, 2026
nicholasjameshall
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category (Required)
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Description
The Python REST sample server was unconditionally setting
checkout.status = CheckoutStatus.READY_FOR_COMPLETEat creation, even without buyer or fulfillment selection, but would rejectcomplete_checkoutwith 400 until fulfillment address and option were selected (as noted in Universal-Commerce-Protocol/ucp#949).This aligns the status assignment with the completion gate:
_has_fulfillment_selectionready_for_completeon create/update only when fulfillment requirements are satisfied; otherwise leaves status asincompleteincompletetest_checkout_readiness_lifecyclecovering the state transition from create (incomplete) -> update with fulfillment (ready_for_complete) -> complete (completed)