Skip to content

chore(models): regenerate against pinned spec for media variants - #102

Open
sakinaroufid wants to merge 1 commit into
Universal-Commerce-Protocol:mainfrom
sakinaroufid:chore/regenerate-media-variants
Open

sakinaroufid wants to merge 1 commit into
Universal-Commerce-Protocol:mainfrom
sakinaroufid:chore/regenerate-media-variants

Conversation

@sakinaroufid

Copy link
Copy Markdown
Contributor

Description

CI regenerates the models against the pinned spec and fails if the committed tree differs.
That check is failing on main.

release/2026-08-25 picked up the media variant schemas in 87dd4b1 ("feat(media): model
image, video, external video, and 3D variants (#690) (#941)"), so regenerating against the
pin now produces 232 modules where 227 are committed:

$ ./generate_models.sh 2026-08-25
postprocess: 36 module(s) patched
Done. Models generated in src/ucp_sdk/models/schemas

$ git status --porcelain src/ucp_sdk/models/schemas
 M src/ucp_sdk/models/schemas/common/types/media.py
?? src/ucp_sdk/models/schemas/common/types/media_external_video.py
?? src/ucp_sdk/models/schemas/common/types/media_image.py
?? src/ucp_sdk/models/schemas/common/types/media_model_3d.py
?? src/ucp_sdk/models/schemas/common/types/media_source.py
?? src/ucp_sdk/models/schemas/common/types/media_video.py

This commit is that output, unedited:

  • media.py gains the Preview model and the current descriptions. The committed copy
    predates the backport.
  • media_image.py, media_video.py, media_external_video.py, media_model_3d.py and
    media_source.py are new.

Post-processing patched its usual 36 modules, so the generated constraints are intact.

Category (Required)

  • Core Protocol: Changes to the base communication layer, global context, or breaking refactors. (Requires Technical Council approval)
  • Governance/Contributing: Updates to GOVERNANCE.md, CONTRIBUTING.md, or CODEOWNERS. (Requires Governance Council approval)
  • Capability: New schemas (Discovery, Cart, etc.) or extensions. (Requires Maintainer approval)
  • Documentation: Updates to README, or documentations regarding schema or capabilities. (Requires Maintainer approval)
  • Infrastructure: CI/CD, Linters, or build scripts. (Requires DevOps Maintainer approval)
  • Maintenance: Version bumps, lockfile updates, or minor bug fixes. (Requires DevOps Maintainer approval)
  • SDK: Language-specific SDK updates and releases. (Requires DevOps Maintainer approval)
  • Samples / Conformance: Maintaining samples and the conformance suite. (Requires Maintainer approval)
  • UCP Schema: Changes to the ucp-schema tool (resolver, linter, validator). (Requires Maintainer approval)
  • Community Health (.github): Updates to templates, workflows, or org-level configs. (Requires DevOps Maintainer approval)

Generated output only. No pipeline, schema or public API changes.

Related Issues

None.

Checklist

  • I have followed the Contributing Guide (including Conventional Commits title requirements and ! for breaking changes).
  • I have updated the documentation (if applicable).
  • My changes pass all local linting and formatting checks.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • (For Core/Capability) I have included/updated the relevant JSON schemas.
  • I have regenerated Python Pydantic models by running generate_models.sh under python_sdk.

No new test or docs: the assertion this restores is the existing model-drift job in
tests.yml, which compares the committed tree against a fresh regeneration.

release/2026-08-25 picked up the media variant schemas in 87dd4b1, so regenerating against the pin produces 232 modules where 227 are committed, and the drift check in tests.yml fails.

Regenerated with ./generate_models.sh 2026-08-25. Generated output only, nothing hand-edited.
@damaz91 damaz91 added the status:needs-triage Signal that the PR is ready for human triage label Oct 22, 2026
@sakinaroufid

Copy link
Copy Markdown
Contributor Author

Hi @damaz91, tagging you because Universal-Commerce-Protocol/ucp#941 is what moved the pinned branch, so you'll have the most context on whether this output looks right.

Quick summary of what happened: python-sdk pins to release/2026-08-25, and CI runs ./generate_models.sh 2026-08-25. Your backport landed the media variant schemas on that branch on 22 Oct, so the pinned spec moved forward while the committed models stayed at their 5 Oct state. That's what the model-drift job has been failing on.

Nothing in this repo changed, and I haven't hand-edited anything here; it's purely the generator's output. It comes to six files: media.py picks up the new fields, and media_image.py, media_video.py, media_external_video.py, media_model_3d.py and media_source.py are new.

If you get a chance, a quick look to confirm they match what you modeled in Universal-Commerce-Protocol/ucp#690 would be great. Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:needs-triage Signal that the PR is ready for human triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants