Skip to content

fix(governance): match AGENT*.md under infra_and_tooling in ucp-rules.yml #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
damaz91 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(governance): match AGENT*.md under infra_and_tooling in ucp-rules.yml #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion org-tools/governance/rules/ucp-rules.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ rules:
- "mkdocs.yml"
- ".gitignore"
- ".linkignore"
- "AGENTS.md"
- "AGENT*.md"
- "CLAUDE.md"
- "pyproject.toml"
- "uv.lock"
Expand Down
14 changes: 14 additions & 0 deletions org-tools/governance/tests/test_governance_config_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,20 @@ def test_validate_no_fallback_failure(self, mock_get_files):
self.assertEqual(errors[0].file_path, "unmatched_file.txt")
self.assertIn("does not match any governance rule", errors[0].message)

def test_ucp_rules_agent_markdown_globs(self):
"""Test that AGENT*.md files in ucp-rules.yml match infra_and_tooling instead of fallback."""
rules_path = Path(__file__).resolve().parent.parent / "rules" / "ucp-rules.yml"
config = GovernanceConfigParser().parse_file(str(rules_path))
reqs = config.get_applicable_requirements(
["AGENTS.md", "AGENT_CONTRIBUTOR.md", "AGENT_IMPLEMENTER.md"]
)
for filename, file_reqs in reqs.items():
self.assertEqual(
len(file_reqs), 1, f"Unexpected requirements for {filename}"
)
self.assertEqual(file_reqs[0].min_team, Team("devops-maintainers", 1))
self.assertEqual(file_reqs[0].min_approvals, 2)


if __name__ == "__main__":
unittest.main()
Loading