FIX: [Port] [UUM-147719] [Input System] Changed input action timeout to not trigger during before-render period - #2486
Open
chris-massie wants to merge 1 commit into
Open
chris-massie wants to merge 1 commit into
chris-massie wants to merge 1 commit into
Conversation
chris-massie
changed the title
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Harness Review
The change consistently defers timeout dispatch during before-render updates across both event-processing branches. I also examined update-type semantics, generic monitor users, and test-state restoration.
Reviewed commit 8851880
🤖 Helpful? 👍/👎
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2486 +/- ##
===========================================
+ Coverage 78.95% 78.97% +0.01%
===========================================
Files 767 767
Lines 140914 141051 +137
===========================================
+ Hits 111262 111393 +131
- Misses 29652 29658 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ritamerkl
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a backport based on https://github.cds.internal.unity3d.com/unity/unity/pull/126600, see original PR for full context. The short version is that this fixes inconsistent timing of when timeouts (such as the Hold interaction) can fire when a before-render input device (e.g., XR HMD) is added or not, improving expected behavior by users.
Testing status & QA
Tested with the repro project the user submitted with the bug, along with some extra verification logging made to their script. I was no longer able to have the Hold interaction on their input action trigger during before-render, which was causing the user's polling during
Update()to miss the interaction phase change.I also added a new unit test that I verified failed before the change to fix/change this behavior. The test steps through the input update phases to make the Hold interaction duration threshold met during the before-render period and verify that the action waits to change to the Performed phase until the next frame.
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
See:
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.