Repository navigation
[TS Calls] Capture class candidates and accept matching replay coverage - #478
Merged
Merged
Conversation
CaelmBleidd
marked this pull request as ready for review
October 13, 2026 23:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calls can lose private-method and constructor paths when a wrapper adds no new entry-function statements. It can also include native replay coverage when symbolic and concrete completions disagree. This PR fixes both boundaries in separate commits.
symbolicCoverageClassin the source manifest selects candidate novelty and the machine's fixed CLASS scope. Constructor/private-method statements contribute; wrapper and foreign-class statements cannot create candidates. Missing or ambiguous classes fail before search. Existing function scope remains the default, and the existing manifest hash/resume guards bind the class selection.Based on main at
5cecdb6743e3d7d0ced3930b198e5a786004766c, including merged #414, #416, #417, #418 and #476. Existing collectors, source replay, common metrics, solver identity and object snapshots are reused.Validation on JDK 21 with the native TypeScript frontend: all 142 Calls tests passed, zero failures/errors/skips. Calls Detekt main/test reported zero findings; diff checks passed. New tests cover four-profile class novelty, private helpers, constructors, exact source paths, foreign/wrapper-only paths, unmapped targets and frozen-manifest scope changes. Emitted fixture inputs replay to both original TypeScript if arms. Native replay checks retain rejected observations while excluding their hits. Two candidate regressions and the checkpoint acceptance regression fail on result assertions with the corresponding fixes disabled.
These changes establish symbolic class novelty and a completion-acceptance gate. Class-only executable source-statement denominators/mapping, constructor plus method-sequence harnesses, shared class scheduling and scenario/solver attribution, returned-value/receiver-state equivalence, class manifests/eligibility and a two-class 30/120-second pilot still remain. A class campaign has not run. Fresh CI for the second commit is pending.