Skip to content

[TS PBT] Integrate exact c8/EtsIR edge feedback into target selection #382

Open

Description

@CaelmBleidd

Current state (2026-10-14)

Audited against usvm main at 19866c959d.

#409 implements exact supported TypeScript if-arm mapping from real c8/V8 evidence, including ordering/offsets and explicit ambiguous cases. The old blanket statement that all c8 branch records are unsupported is historical.

Remaining acceptance boundary

Complete the remaining #399/#355 integration: actual independent PBT edge-coverage changes must change symbolic target selection, including saturated-statement/unvisited-edge cases. Retain source/property/phase provenance, wrapper separation and explicit unsupported constructs; mapping an artifact alone does not close this integration gate.

Delivery ownership clarified on 2026-10-14

The bounded branch reconstruction is present in merged PR #409. Reuse it; do not restart the converter implementation. Preserve its exact supported construct boundary.

#396 supplies admitted input/phase/context provenance for evidence used as feedback; #399/#481 consume exact outcomes; #355/#405 own the complete cooperation chain. The real-backend integration gate below remains required, but it does not require hypothesis inference to start or prove the converter's isolated contract.

For the supported fixture, native evidence must distinguish admitted tested-program execution from rejected-input/precondition and wrapper execution. Aggregate-only evidence with unknown admission/context must not be promoted to an exact feedback fact. No unbounded per-statement execution tracer is required.

Original report and acceptance context, retained for traceability

Part of #345. Depends on #350. Required for exact branch feedback in the core #355/#405 result and its coverage-only control, as well as the full #345 result. It does not block the no-feedback #354 control, initial observation work or partial relation integration; those activities must report their coverage capability explicitly. Selection of a conversion tool should follow the measured cases below, without creating a general converter framework.

Goal

Map branch coverage produced by the pinned c8/V8 backend to TypeScript branch arms and EtsIR CFG edges.

Why

#350 and #381 map backend-neutral binary Istanbul if records to ordered true/false EtsIR successors. The current c8@10.1.3 path uses v8-to-istanbul@9.3.0, which converts every V8 block range into an independent Istanbul-shaped record with type: "branch" and exactly one location/count.

For example, when only the true side of an if/else runs, raw V8 coverage contains a zero-count range for the unexecuted else. When only the false side runs, it contains a zero-count range for the true body. The converted report does not preserve the originating if, the relationship between its arms, or the true/false outcome. It also emits similar records for function and script ranges. Therefore #381 reports these records as UNSUPPORTED instead of guessing CFG edges, while retaining usable statement mappings.

Statement coverage cannot reveal every missed edge. For example, if only the true side of an if without an else runs, every statement may be covered while the false edge remains untested.

Scope

  • Evaluate an AST-aware V8-to-Istanbul converter, including Monocart, before implementing a custom conversion.
  • Preserve enough raw V8 range hierarchy and source-map information to associate coverage with original TypeScript constructs.
  • Produce backend-neutral binary if coverage with explicit true and false arms when the association is exact.
  • Map those arms to ordered EtsIR CFG successors through the mapping layer introduced in [TS PBT] Map property coverage to EtsIR #381.
  • Report ambiguous or unsupported cases instead of inferring an edge.
  • Keep successfully mapped statement coverage available when branch reconstruction is not possible.
  • Document which TypeScript branch constructs are supported; do not silently treat switch, conditional expressions, or logical short-circuit ranges as binary if records.

Definition of Done

  • A real c8 run over a TypeScript if/else produces two correctly ordered backend-neutral arms and maps them to the true and false EtsIR successors.
  • Separate true-only, false-only, and mixed executions preserve correct hit counts.
  • Nested conditions, an if without else, source-map remapping, and ambiguous ranges have explicit tests and behavior.
  • Function-level and script-level V8 block ranges are not misclassified as EtsIR conditional edges.
  • Partial failures do not discard exact statement mappings.

Follow-up to #350 and #381.

Integration with property-aware feedback

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions