Repository navigation
[TS] Preserve hoisted mutable named function bindings - #430
Merged
Merged
Conversation
Contributor
Select template tags from the live binding before substitutions and preserve receivers, reference order, and iterator-close regressions.
CaelmBleidd
force-pushed
the
caelmbleidd/ets-named-function-bindings
branch
from
October 10, 2026 17:43
c0a8f51 to
cffa932
Compare
CaelmBleidd
marked this pull request as ready for review
October 10, 2026 17:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Named scope functions now have one hoisted mutable binding, so aliases retain the selected function and later calls observe reassignment. Calls and template tags select their callee before argument/substitution side effects; original body ownership and property receivers are preserved.
The delivery is rebased onto the complete lowering stack in neo. It also adapts tagged-template lowering to the live binding and adds a native/serialized-IR regression for reassignment during a substitution.
Validation: independent core and hygiene review of the exact combined tree; fresh frontend build and 635 passing tests. The combined ETS suite passed 233 tests with one inherited Demo_Calc project fixture skip (EtsFromJsonTest.testLoadEtsProject); the for-await fixture corrections were delivered separately in #421/#422. Normal license hook passed. A fresh complete ETS run on this tree plus the unchanged #427 process fix passed 235 tests with one inherited Demo_Calc project fixture skip (EtsFromJsonTest.testLoadEtsProject). Final integrated checks are recorded separately from original-head CI.
Boundary: direct imported namespace property calls/tags remain explicitly unsupported because their module receiver is not represented. Frontend/JSON correctness does not establish downstream USVM execution support or update its dependency pin.