Skip to content

Follow-up from #38: backup browser refresh with no backups, and housekeeping (2.0.1) #39

Open

Description

@wisdommen

Follow-up from #38 (2.0.0 preparation). None of these blocks 2.0.0; they are scheduled for 2.0.1. Paths are relative to the repository; line numbers refer to aa09fb0.

Defect

  1. Backup browser does not refresh after it was opened with no backups. src/main/java/com/ultikits/plugins/backup/gui/BackupGUI.java:51 keeps the list returned by backupService.getBackups(...), and refresh() (:221-225) calls clear()/addAll() on it. When the browser was opened while the player had no backups, that list can be unmodifiable, so refresh() throws UnsupportedOperationException and the browser keeps showing the old (empty) contents.
    • Trigger: a player with ultibackup.use who has no backups yet opens /backup and clicks the create-new-backup button.
    • Effect: the backup is created and stored, but the open browser does not show it. No data is lost.
    • Workaround: close and reopen the browser (/backup).
    • Present since: 1.0.0 (same code).
    • Fix: copy into a mutable list (this.backups = new ArrayList<>(...)) or replace the list in refresh(); add a test that opens the browser with zero backups, creates one and refreshes.

Housekeeping

  1. README.md:243: the version history still ends at v1.0.0; add 2.0.0.
  2. src/main/java/com/ultikits/plugins/backup/UltiBackup.java:14: the @version javadoc tag still says 1.0.0.

Dependabot pull requests that edit the deleted publish workflow

  1. release: prepare UltiBackup 2.0.0 for UltiTools-API 6.3.0 (no publishing on merge) #38 deletes .github/workflows/publish.yml. Open Dependabot pull requests that edit it: build(deps): Bump actions/setup-node from 4.4.0 to 7.1.0 #37 is closed (it changed only that file); build(deps): Bump actions/checkout from 5.0.1 to 7.0.1 #10 and build(deps): Bump actions/setup-java from 5.2.0 to 6.1.0 #20 are asked to recreate against the new master so that only their maven-ci.yml change remains. Do not resolve a conflict on any of them by keeping publish.yml: restoring that workflow would publish a release on the next push to master.

中文:#38 的后续事项,均不阻塞 2.0.0,计划在 2.0.1 处理。主要是一个自 1.0.0 起就有的界面问题:玩家在没有任何备份时打开 /backup、再点新建备份,备份已保存但界面不刷新,关闭重开即可看到。

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions