You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Follow-up from #38: backup browser refresh with no backups, and housekeeping (2.0.1) #39
Follow-up from #38 (2.0.0 preparation). None of these blocks 2.0.0; they are scheduled for 2.0.1. Paths are relative to the repository; line numbers refer to aa09fb0.
Defect
Backup browser does not refresh after it was opened with no backups.src/main/java/com/ultikits/plugins/backup/gui/BackupGUI.java:51 keeps the list returned by backupService.getBackups(...), and refresh() (:221-225) calls clear()/addAll() on it. When the browser was opened while the player had no backups, that list can be unmodifiable, so refresh() throws UnsupportedOperationException and the browser keeps showing the old (empty) contents.
Trigger: a player with ultibackup.use who has no backups yet opens /backup and clicks the create-new-backup button.
Effect: the backup is created and stored, but the open browser does not show it. No data is lost.
Workaround: close and reopen the browser (/backup).
Present since: 1.0.0 (same code).
Fix: copy into a mutable list (this.backups = new ArrayList<>(...)) or replace the list in refresh(); add a test that opens the browser with zero backups, creates one and refreshes.
Housekeeping
README.md:243: the version history still ends at v1.0.0; add 2.0.0.
src/main/java/com/ultikits/plugins/backup/UltiBackup.java:14: the @version javadoc tag still says 1.0.0.
Dependabot pull requests that edit the deleted publish workflow
Activity