Skip to content

Add RSC_ERASE_FLASH proto command to master (fixes FCB master build) - #21

Open
Jad-Dina19 wants to merge 3 commits into
masterfrom
local/build-fix
Open

Jad-Dina19 wants to merge 3 commits into
masterfrom
local/build-fix

Conversation

@Jad-Dina19

Copy link
Copy Markdown

Why

FCB master's RadioProtoTask.cpp handles Proto::FcbCommand::Command::RSC_ERASE_FLASH, but that enum value only exists on side branches of this repo (Andrey/IREC2026, adamg/camcommands, adamg/irctramp) — it was never merged to master. As a result, FCB master does not compile on a fresh clone (error: 'RSC_ERASE_FLASH' is not a member of 'Proto::FcbCommand::Command').

This PR merges the proto commit (9fb7b8a "generate proto files") onto master so the definition and FCB's code agree. FCB has been built and linked successfully against this merge.

⚠️ Heads-up for ground station / tooling: enum renumbering

This change is not purely additiveRSC_ERASE_FLASH takes over value 36 and RSC_NONE moves from 36 to 37:

RSC_ERASE_FLASH = 36;
RSC_NONE = 37;   // Invalid command, must be last

Any system built against the old definition disagrees about what 36 means on the wire: an old-proto sender transmitting RSC_NONE (36) would be decoded by updated firmware as RSC_ERASE_FLASH — a destructive command. RSC_NONE appears to be a never-transmitted sentinel, but please update GUI/Python tooling and firmware in the same coordinated step.

Changes

  • SoarProto/Aegis/CommandMessage.proto — add RSC_ERASE_FLASH = 36, move RSC_NONE to 37
  • SoarProto/Aegis/_C++/CommandMessage.hpp — regenerated
  • SoarProto/Aegis/_Python/CommandMessage_pb2.py / .pyi — regenerated

After merge, FCB should bump its SoarCommunications submodule pointer to the new master commit.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants