fix(runner): run bench file teardown before aborting on a bad annotation - #1330
Merged
Chemaclass merged 1 commit intoAug 19, 2026
Merged
Conversation
A malformed benchmark annotation aborted the run with `exit 1` from inside call_bench_functions. set_up_before_script had already run, and the file's tear_down_after_script never did. Return the failure to the bench loop instead, so the file's cleanup block runs, and abort from there. The annotation error still stops the whole run with the same message and exit code: a value the runner cannot honour would otherwise measure something other than what the annotation asked for (#884). The test runner has the same defect through its own @timeout/@Retry validation. Filed separately as #1329 rather than widened into this fix. Closes #1322
Chemaclass
deleted the
fix/1322-bench-aborts-without-tear-down-after-script
branch
August 19, 2026 18:50
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Related #1322
A malformed benchmark annotation aborts
bashunit benchwithexit 1from insidecall_bench_functions.set_up_before_scripthas already run at that point, so the file'stear_down_after_scriptnever does and whatever it acquired is leaked.💡 Changes
@timeout/@retryvalidation, in a different frame. Filed as A malformed@timeoutor@retryaborts the run without runningtear_down_after_script#1329 rather than widened into this fix.