Repository navigation
馃敡(dev-instance) raise the document access throttle for the history panel - #8
Merged
Merged
Conversation
yhub checks the access of each history request with the backend (/documents/<id>/accesses/me/). The default throttle of 50 requests per minute for each user made the backend answer 429, and yhub then answered 503. Clicking through the history panel reached this limit quickly. Signed-off-by: yousefed <yousefdardiry@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The history panel often failed with 503 errors.
/api/v1.0/documents/<id>/accesses/me/.API_DOCUMENT_ACCESS_THROTTLE_RATE, upstream default).The backend log showed many "Too Many Requests" warnings for
accesses/me/at the same times as the 503 errors in the frontend log.Change
deploy/dev-instance/compose.yaml: the dev instance setsAPI_DOCUMENT_ACCESS_THROTTLE_RATEandAPI_DOCUMENT_THROTTLE_RATEto1000/minute. Production defaults do not change.Note for the versioning work
With the upstream default, the history panel can fail for normal use. Upstream Docs probably needs a higher limit for the access check that yhub makes, or yhub must cache the result of the access check.