Repository navigation
🐛(frontend) keep the compared versions when the diff fixes change - #7
Merged
Merged
Conversation
A change of the "Version diff fixes" select created the editor again. The History panel then opened again and selected the latest version, so the selected version and the version it was compared to were lost. BlockNote reads the experimental options each time it shows a version. The editor now keeps one options object, changes it, and shows the selected versions again. The editor is not created again. Signed-off-by: yousefed <yousefdardiry@gmail.com>
|
Size Change: +10 B (0%) Total Size: 4.23 MB 📦 View Changed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When you change the "Version diff fixes" select in the History debug panel, the History panel must keep the selected version and the version that it is compared to.
Problem
A change of the select created the editor again. Then the History panel opened again with a new versioning store. The panel selected the latest version, and the selected version and the version that it was compared to were lost. After some changes, no version was selected at all.
Cause
The editor got the experimental diff options when it was created, so a new value needed a new editor. But BlockNote does not need a new editor: it reads the experimental options each time it shows a version.
Changes
The grouping settings ("Apply" and "Reset") do not create the editor again. They keep the selection already.
How to test