Skip to content

🐛(frontend) keep the compared versions when the diff fixes change - #7

Merged
YousefED merged 1 commit into
devfrom
fix/keep-history-selection
Oct 9, 2026
Merged

YousefED merged 1 commit into
devfrom
fix/keep-history-selection

Conversation

@YousefED

@YousefED YousefED commented Oct 9, 2026

Copy link
Copy Markdown

Purpose

When you change the "Version diff fixes" select in the History debug panel, the History panel must keep the selected version and the version that it is compared to.

Problem

A change of the select created the editor again. Then the History panel opened again with a new versioning store. The panel selected the latest version, and the selected version and the version that it was compared to were lost. After some changes, no version was selected at all.

Cause

The editor got the experimental diff options when it was created, so a new value needed a new editor. But BlockNote does not need a new editor: it reads the experimental options each time it shows a version.

Changes

  • The editor keeps one experimental options object for its full life.
  • When you change the select, the editor changes this object and shows the selected versions again. The editor is not created again.
  • The hint below the select tells that the selected versions are shown again.

The grouping settings ("Apply" and "Reset") do not create the editor again. They keep the selection already.

How to test

  1. Open the sample document "07/10 meeting agenda (sample)" and open History.
  2. Select "08:35:02–08:38:51 UTC" and turn on the comparison. The panel compares it to "First · 07:10:10–07:15:01 UTC".
  3. Open "History debug" and change "Version diff fixes" some times. Make sure that the same two versions stay selected, and that the diff changes.
  4. Click "Editing sessions", then "Apply", then "Reset". Make sure that the same two versions stay selected.

A change of the "Version diff fixes" select created the editor again.
The History panel then opened again and selected the latest version, so
the selected version and the version it was compared to were lost.

BlockNote reads the experimental options each time it shows a version.
The editor now keeps one options object, changes it, and shows the
selected versions again. The editor is not created again.

Signed-off-by: yousefed <yousefdardiry@gmail.com>
@YousefED
YousefED merged commit bcf3495 into dev Oct 9, 2026
18 of 19 checks passed
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Size Change: +10 B (0%)

Total Size: 4.23 MB

📦 View Changed
Filename Size Change
apps/impress/out/_next/static/9ff3543f/_buildManifest.js 719 B +719 B (new file) 🆕
apps/impress/out/_next/static/c5bd549c/_buildManifest.js 0 B -719 B (removed) 🏆
apps/impress/out/_next/static/css/ac8d3a415e0781c3.css 0 B -13.7 kB (removed) 🏆
apps/impress/out/_next/static/css/bb02454244f49bf6.css 13.7 kB +13.7 kB (new file) 🆕

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant