Skip to content

Fix Race Condition for EstimationRun Unit Test #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamesVaughan merged 1 commit into from
Oct 15, 2026
Merged

Fix Race Condition for EstimationRun Unit Test #222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 31 additions & 2 deletions tests/XTMF2.UnitTests/TestOptimizationRun.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,35 @@ public void EstimationRun_DoesNotCrash()

// ── run ────────────────────────────────────────────────────────────
var runDirectory = Path.Combine(pSession.RunsDirectory, "EstimationRun");
string[] reportLines = null;
CreateRunClient(true, (runBus) =>
{
bool success = false;
using SemaphoreSlim sim = new SemaphoreSlim(0);
using SemaphoreSlim artifactsReady = new SemaphoreSlim(0);
string runId = null;
Exception artifactError = null;

EventHandler<HostBus.RunArtifactsReceivedEventArgs> onArtifactsReceived = (sender, e) =>
{
if (e.RunId != runId)
return;

try
{
RunArtifactMirror.ExtractToDirectory(e.MirrorPath, runDirectory);
reportLines = File.ReadAllLines(Path.Combine(runDirectory, "estimation_report.csv"));
}
catch (Exception exception)
{
artifactError = exception;
}
finally
{
artifactsReady.Release();
}
};
runBus.ClientRunArtifactsReceived += onArtifactsReceived;

runBus.ClientFinishedModelSystem += (sender, e) =>
{
Expand All @@ -95,15 +120,19 @@ public void EstimationRun_DoesNotCrash()

Assert.IsTrue(runBus.RunModelSystem(msSession,
runDirectory,
"Start", RunMode.Estimation, out _, out error), error?.Message);
"Start", RunMode.Estimation, id => runId = id, out _, out error), error?.Message);

if (!sim.Wait(30000))
Assert.Fail("Estimation run timed out after 30 seconds.");

Assert.IsTrue(success, "Estimation run did not complete successfully: " + error?.ToString());

if (!artifactsReady.Wait(30000))
Assert.Fail("Estimation run artifacts were not received after completion.");
runBus.ClientRunArtifactsReceived -= onArtifactsReceived;
Assert.IsNull(artifactError, artifactError?.ToString());
});

var reportLines = File.ReadAllLines(Path.Combine(runDirectory, "estimation_report.csv"));
Assert.AreEqual("Iteration,Fitness,Param", reportLines[0]);
Assert.IsGreaterThan(1, reportLines.Length, "The estimation report should contain evaluation rows.");
});
Expand Down
Loading