Skip to content

fix(examples): replace comma with dot in XmlnsUrl across fare examples - #1082

Merged
TuThoThai merged 4 commits into
TransmodelEcosystem:v2.0from
assassinationss:fix-invalid-uris-fares-examples
Oct 8, 2026
Merged

TuThoThai merged 4 commits into
TransmodelEcosystem:v2.0from
assassinationss:fix-invalid-uris-fares-examples

Conversation

@assassinationss

Copy link
Copy Markdown
Contributor

Fixes the invalid URIs reported in the issue: several fare examples have a comma instead of a dot between TLD and SLD in <XmlnsUrl> (http://www.myfares,com/fares).

I swept the whole repo for the same pattern — all 10 occurrences are in examples/functions/fares/, one <XmlnsUrl> per file — and fixed them all, not just the three files listed in the issue. No other content touched.

Closes #1063

@skinkie skinkie self-assigned this Sep 24, 2026
@skinkie skinkie added the typo Typo (comment or mispelling) correction without any technical impact label Sep 24, 2026
@assassinationss

Copy link
Copy Markdown
Contributor Author

Thanks @ue71603 and @skinkie for the double review. Happy to rebase or amend anything if needed before this lands.

@TuThoThai TuThoThai added this to the netex_2.0 milestone Sep 28, 2026
@TuThoThai

Copy link
Copy Markdown
Contributor

@assassinationss, thanks for cleaning the typos!

@thbar and I will cross-check the CI situation and this PR will be merged. Then, we will handle the backport to v2.1-wip

@thbar

thbar commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

@thbar and I will cross-check the CI situation and this PR will be merged.

@TuThoThai I checked:

@assassinationss

Copy link
Copy Markdown
Contributor Author

@thbar — no rush at all, but if it helps: the fork-CI part of #1052 looks like a single hunk in .github/workflows/ci.yml (about 7 lines).

I'd be glad to prepare the v2.0 backport as a PR for your review if that saves you a chore — or equally happy to leave it in your hands, since it's your call how the branch is maintained.

@thbar

thbar commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

@thbar — no rush at all, but if it helps: the fork-CI part of #1052 looks like a single hunk in .github/workflows/ci.yml (about 7 lines).

I'd be glad to prepare the v2.0 backport as a PR for your review if that saves you a chore — or equally happy to leave it in your hands, since it's your call how the branch is maintained.

@assassinationss thanks for the ping & offer to help. It turns out the backport in question is already available here for review!

(I also just merged #1077, so we'll see how things pan out)

@thbar

thbar commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

(In theory once #1083 is merged, and the current #1082 made up-to-date, the idea is that the CI should complete here - if it does not I will investigate)

@thbar

thbar commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

@TuThoThai after the 2 merge, + click on "approve workflow to run" (due to "external" contribution), the CI is started 😄 the hope is good.

@TuThoThai
TuThoThai merged commit dc6f162 into TransmodelEcosystem:v2.0 Oct 8, 2026
1 check passed
@assassinationss

Copy link
Copy Markdown
Contributor Author

Merged — thank you both! 🎉 Glad the v2.0 sync + workflow approval got the CI unstuck. Happy to help with anything else on the examples or docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

typo Typo (comment or mispelling) correction without any technical impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid URI in some examples

5 participants