Repository navigation
Skip the tests the suite turns off, and report them as skipped - #64
Merged
Merged
Conversation
translator-testing-model 0.7.0 adds skip and skip_reason to test assets and test cases, for tests that always fail for a known reason. A skipped asset isn't queried (nor is a test case whose assets are all skipped), and a skipped performance test doesn't start HelmsDeep. Each is still reported, as SKIPPED with "Skipped in the suite: <reason>", in Slack, the CSV, Zebrunner and the Information Radiator, which already leaves skips out of pass rates. --include_skipped runs them anyway, to see whether the issue behind them is fixed. The radiator: a performance result can carry a message (migration 0009). A skipped one reads "not load tested" with its reason, raises no flags on the cycle board, and is never the baseline the next run is compared with. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S2yuREtzxTuRqVGp8Q8a6d
Collaborator
Author
|
Run pytest is red only because The fix is the model release, not a change here: merge TranslatorSRI/TranslatorTestingModel#44 (green on 3.10–3.12), then create the Checked: with a 0.7.0 wheel built from #44's head ( Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
translator-testing-model 0.7.0 (TranslatorSRI/TranslatorTestingModel#44) adds
skipandskip_reasonto test assets and test cases, for tests that always fail for a known reason. CI will fail at install untiltranslator-testing-model==0.7.0is on PyPI.Harness
SKIPPED, with the messageSkipped in the suite: <reason>, in Slack, the CSV, Zebrunner and the Information Radiator. The radiator already leaves skips out of pass rates, and its diff files a change to or from skipped under "skipped", not as a regression.--include_skipped: runs the skipped tests anyway, to see whether the issue behind them is fixed.test-harness-cycleandtest-harness-sweeppass it on when it's given after the--.Information Radiator
message, viaradiator_schemaand migration0009. It's an addition, so the schema version stays 2.Testing
tests/test_skip.py, which checks:--include_skippedruns everything;alembic checkis clean.tests/test_skip.pyimportstest_harness.mainfirst, like the real entry point. gevent's monkey-patching has to come before anything starts a thread; otherwise the file, run on its own with output to a pipe, hung at exit.Rollout
skipin NCATSTranslator/Tests data, since an older harness can't read a suite that uses it. The Tests repo also getstest_generators/sync_asset_copies.py, which copies an asset edit, egskip: true, into the copies the suites carry, keeping every test case ID.Generated by Claude Code