Repository navigation
Multi-CURIE expected outputs, a run-level --env, and shared suites in the radiator - #62
Merged
Merged
Conversation
Test assets now name their expected output with output_ids, a list (translator-testing-model 0.6.0), so an answer Translator returns under any of its identifiers counts, eg sirolimus as CHEBI:9168 or PUBCHEM.COMPOUND:5284616 now that node normalization keeps them apart. Each CURIE is judged as a single CURIE was before. TopAnswer and Acceptable pass if any of them passes; BadButForgivable and NeverShow fail if any of them fails. The rank and score reported are the best-ranked match's (before, a CURIE bound by several results reported the last one), and found_curies records which CURIEs came back, so an answer split across several shows up on the dashboard. Information Radiator: AssetResult.output_curie becomes the list output_curies and AgentResult gains found_curies (schema version 2; version 1 records, eg runs saved before this, are still read). Migration 0007 converts existing rows. Zebrunner's OutputCurie label comma-separates several CURIEs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S2yuREtzxTuRqVGp8Q8a6d
Suites are the same in every environment, so test cases no longer say which one they run in (translator-testing-model 0.6.0 drops test_env). test-harness takes a required --env (dev, ci, test or prod), and everything that read test.test_env uses it: the services queried, the node normalizer, the TRAPI version check, CI's cache bypass, and the environment Zebrunner and the Information Radiator record for the run. test-harness-cycle and test-harness-sweep take --env too and pass it to every run. The Helm chart's cycles test the environment their entry is named for (or its env), all with the same suites (mvp_tests, pathfinder_tests, performance_tests); the sweep needs sweep.env. The bundled local suites, examples and docs are updated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S2yuREtzxTuRqVGp8Q8a6d
The Tests repo's per-environment copies of a suite become one suite run in every environment (mvp_tests, pathfinder_tests), so runs recorded under an old name (sprint_6_tests, dev_refactor_tests, test_integration, prod_integration, pathfinder_tests_TEST, pathfinder_tests_PROD) are filed under the shared one, keeping the old name in runs.source_suite. Migration 0008 renames the runs already recorded; ingest renames any that arrive later, eg a run saved before the switch. A series is still suite, env, target and query type, so each environment's history, trends and diffs carry on from its old copy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S2yuREtzxTuRqVGp8Q8a6d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches the harness and the Information Radiator to translator-testing-model 0.6.0 (TranslatorSRI/TranslatorTestingModel#43). CI will fail at install until
translator-testing-model==0.6.0is on PyPI.Match an expected output on any of its CURIEs
Test assets name their expected output with
output_ids, a list.found_curies, the CURIEs that came back, best first. More than one means Translator split the answer.radiator_schemaversion 2):AssetResult.output_curiebecomesoutput_curies, andAgentResultgainsfound_curies. Version 1 records, such as saved runs, are still read. Migration0007converts existing rows.OutputCurielabel comma-separates several CURIEs.--env: the run says which environment it testsSuites are the same in every environment, and 0.6.0 drops
test_envfrom test cases.test-harnessnow requires--env {dev,ci,test,prod}. It drives the services queried, the node normalizer, the TRAPI version check, CI's cache bypass, and the environment Zebrunner and the radiator record.test-harness-cycleandtest-harness-sweeptake--envand pass it to every run.env), and every entry defaults tomvp_tests,pathfinder_testsandperformance_tests. The sweep needssweep.env.run-step.shkeeps--env. Compose has aHARNESS_ENVsetting.The radiator: one history per shared suite
Runs recorded under the old per-environment copies are filed under the shared suite, keeping the old name in
runs.source_suite:sprint_6_tests,dev_refactor_tests,test_integration,prod_integrationmvp_testspathfinder_tests_TEST,pathfinder_tests_PRODpathfinder_testsA history line is still suite, env, target and query type, so each environment's history, trends and diffs carry on from its own old copy. Migration
0008renames the runs already stored, and ingest renames any that arrive later, such as a run saved before the switch. A run's page says what it was recorded as.Testing
--env. A 20,000-case comparison against the old analysis found no pass/fail difference for single-CURIE assets.alembic checkis clean. Migrations 0007 and 0008 were tested up and down on sample rows.helm-lintjob will do that.Rollout
Generated by Claude Code