Repository navigation
fix(backend): return 400 for a malformed day on the relay locations endpoint - #632
Merged
Merged
Conversation
…ndpoint
GET /relay/location/day/{day} threw an uncaught DateTimeParseException for
input like "abc", so clients got a 500 and every request logged a stack trace.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KMBPvGbLvfEphgrSMN39Ft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /relay/location/day/{day}calledLocalDate.parse(day)on the raw path variable. Input likeabcor2026-13-45threw an uncaughtDateTimeParseException, so clients got a 500 and every such request logged an ERROR with a stack trace (verified on api.tormap.org:/relay/location/day/abcreturns 500).CacheServiceis unaffected.RelayLocationControllerTest(valid day → 200, five malformed days → 400).Testing
Not run.
./gradlew testfailed at dependency resolution (Maven Central returned HTTP 429 in this environment, twice). Please rely on CI before merging. The PR is a draft for that reason.Deployment notes
None.
Suggested labels:
bug,backend.Generated by Claude Code