Repository navigation
fix(frontend): render map relay tooltips as text - #631
Conversation
The relay marker tooltip was passed to Leaflet as a HTML string. Nicknames are limited to [0-9a-zA-Z]{1,19} by the descriptor parser today, so this is not exploitable, but THREAT_MODEL.md forbids string tooltips for relay-derived fields. Use a text node like the country usage layer.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015Cf2Sci2amhHihBa9yt91x
|
The Generated by Claude Code |
|
Generated by Claude Code |
Summary
layer-construction.tswas passed to Leaflet as a HTML string. Nicknames are limited to[0-9a-zA-Z]{1,19}by the vendored parser, so this is not exploitable today (low severity, defense in depth), butTHREAT_MODEL.mdforbids Leaflet string tooltips for relay-derived fields.textContent, and a new test checks that markup in a nickname is not interpreted.Testing
yarn install --immutable,yarn build,yarn lint: pass.yarn test:run: 347/347 pass (Chromium browser tests included)../gradlew testand Docker builds were not run: Maven Central returned 429 and there is no Docker daemon in this environment. The change touches onlyfrontend/src.Deployment notes
None.
Suggested labels:
bug,frontend(hardening, not a vulnerability fix).Generated by Claude Code