Repository navigation
fix(frontend): load map tiles from CARTO's rastertiles endpoint - #630
Conversation
The legacy {s}.basemaps.cartocdn.com/dark_all URLs return some tiles in a
different style, which shows up as lighter rectangles on the dark map.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PdYR45tHetg1e9kVBQhLvM
|
Generated by Claude Code |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
|
GitGuardian failed on the CARTO Basemaps key. This PR doesn't add the key: it has been on The key is used in the browser to fetch tiles, so it ends up in the public JS bundle however it's stored. Moving it to a build-time Generated by Claude Code |
|
Generated by Claude Code |
Previews kept for 30 days filled up the Firebase Hosting channel quota. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PdYR45tHetg1e9kVBQhLvM
|
Visit the preview URL for this PR (updated for commit 822c611): https://tormap-36f44--pr630-claude-project-threa-by67izy9.web.app (expires Tue, 27 Oct 2026 22:35:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 0c1f71965de18e60b0e686b0d0356977fec090dc |
The new CARTO dark_all tiles use #2e353b for water, so the #262626 background around the tiles stood out. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PdYR45tHetg1e9kVBQhLvM
Requested by ju · project thread
What
Some tiles of the dark map render with a lighter, bluish water colour (
#2e353b) while the rest use#262626, so the map shows tile-aligned rectangles at every zoom level.The affected tiles don't follow the
{s}subdomain rotation, and the frontend draws only a single tile layer, so the mismatch is coming from the tiles CARTO serves. Since CARTO started requiring a key (db971a8), the endpoint it documents isbasemaps.cartocdn.com/rastertiles/dark_all/.... We were still using the legacy{s}.basemaps.cartocdn.com/dark_all/...path.Changes
https://basemaps.cartocdn.com/rastertiles/dark_all/{z}/{x}/{y}{r}.png?key=…(same key, no subdomains)index.htmlwith the single host#2e353b, so the area outside the tiles matchesDeploy Previewfail.Testing
tsc --noEmitand eslint pass🤖 Generated with Claude Code
https://claude.ai/code/session_01PdYR45tHetg1e9kVBQhLvM