Repository navigation
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1141 +/- ##
========================================
Coverage 99.91% 99.91%
========================================
Files 112 113 +1
Lines 13454 13506 +52
Branches 1610 1611 +1
========================================
+ Hits 13443 13495 +52
Misses 5 5
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
shaneahmed
changed the title
contrast_enhancer to rust
abdol
left a comment
abdol
left a comment
There was a problem hiding this comment.
Thank you for your work @hannah275. Please find my feedback below.
| from tiatoolbox import utils | ||
|
|
||
|
|
||
| def test_contrast_enhancer() -> None: |
There was a problem hiding this comment.
It seems like contents of this file are duplicated in the other PR #1142. Is that intentional?
| output_array = utils.misc.contrast_enhancer(input_array, low_p=2, high_p=98) | ||
| # The out_put array should be equal to expected result_array | ||
| assert np.all(result_array == output_array) | ||
| # Calculating the contrast enhanced version of input_array |
There was a problem hiding this comment.
Similar to the comment above, lines 918-952 are duplicated in #1142.
|
View / edit / reply to this conversation on ReviewNB abdol commented on 2026-09-25T17:04:23Z It seems like this is the same file in the other PR. If so, please refer to my feedback on the notebook there. Thank you |
|
Whilst working on this PR, I realised that a Rust compiler does not get installed with the toolbox when following the step in README. I will work on adding first. |
|
Hi @shaneahmed, hope you're well. I have started to make changes in a new branch as Hannah's branch is in a fork. I think we'd need to create a new PR with the new branch as I'm not aware of a way to repoint a PR to a different branch. Are you happy for me to close this PR and open a new one? (this will retain Hannah's commits to the repo) Thanks |
|
@abdol Please go ahead and create a new branch unless @hannah275 can provide you write access. |
|
Closing this PR and continuing in #1174. |
No description provided.