[mkarlesky]

Fifth and last PR in the lint-and-coverage series, stacked on #24. It adds integration tests that drive the real extension in VS Code against a fake Ceedling. It also carries the series' final pass: a last lint, and a thorough review of every change in #21–#25, with its findings fixed here.

Fake Ceedling

• The fake: tests/fixtures/fake-ceedling/ceedling.js is a Node script. It answers version, dumpconfig --stdout, files:test, test: tasks, clean and clobber as Ceedling 1.2.0 does, from the scenario file fake-ceedling.json in the project.
  • Its CppUnit reports follow the structure of the captured real reports.
  • Its compiler failure is the captured ceedling-1.0.0/compile-failure-stderr.txt.
  • It logs every invocation, so the tests check the arguments the extension passes.
• The workspace: tests/integration/main.ts copies tests/fixtures/workspace-fake-ceedling to a temporary directory and points ceedlingExplorer.ceedlingCommand at the fake. It opens that copy alongside the existing workspace-without-project as a two-folder workspace, so builds never write into the repository.
• The test handle: VS Code's API can't read another extension's TestItems or run results. So activate() returns CeedlingExplorerApi, which gives the tests each folder's controller. The controller adds onDidReport, whenDiscovered() and run() for them.

Scenarios (10 new; 14 integration tests in all)

• A folder without a project gets no TestController, and Ceedling never runs there.
• Discovery: the files from files:test, functions and cases with their pretty labels and lines, and the controller named for its folder.
• A file run: passed, failed (message, and location at the assertion's line), ignored, and parametrized cases. The fake's log confirms --force-test-rerun and the bundled mixin.
• A function run: --test-case=<name> reaches Ceedling, and only that function reports.
• A function run whose filter, as a substring match, also selects another function: the engine reruns the whole file.
• An unreported test errors, naming the likely cause.
• A compile failure errors the file's tests and reaches the Problems panel at the captured error's line.
• Cancellation stops the hung fake and marks the test skipped.
• A test file created on disk is discovered, and one deleted goes away.
• An unsaved edit adds a test to the tree, and reverting removes it.

On the Windows CI leg these run the engine with Windows paths, which unit tests can't reach.

Final pass

Lint: 0 findings. The ban on synchronous fs calls in src/ now covers every synchronous fs method.

Review: four parallel reviews covered every change in #21–#25 against next_version, by area:

• engine and concurrency;
• adapters and extracted modules;
• parsing and planning modules;
• tests, tooling, docs, and style.

Each finding was checked against the code before any fix, and each fix that changes behavior was written test-first.

Fixed

Finding	Where	Fix
Windows: testFileAt never matched. Discovery uppercases the drive letter for gcov, but VS Code reports c:\…, and the comparison was exact. Unsaved-edit, save, and close reparses silently did nothing. The new Windows integration leg failed on it. Introduced on next_version, never released.	ceedlingEngine.ts	pathKey() compares Windows paths case-insensitively.
Windows: one directory could get two lock keys. An absolute projects[].path kept a lowercase drive letter, and directory locks keyed on the raw path. Two spellings of one directory could then build at once, the corruption the lock exists to prevent.	ceedlingProjectConfig.ts, ceedlingEngine.ts	Every project path gets an uppercase drive letter, and locks and discovery groups key on pathKey().
A captured line or column of 0 (GCC's <command-line>:0:0:) became −1. vscode.Position then threw, dropping every diagnostic from that pattern for the run. Shipped in 2.0.1.	problemMatching.ts	Positions clamp at 0. Added to the CHANGELOG.
extractTestFunctionName split at the last ::. test_s("a::b") gave b"), causing a false collision warning and a whole-file rerun. Shipped in 2.0.1.	ceedlingOutputParsing.ts	It splits at the first ::. Added to the CHANGELOG.
A cancelled Clean or Clobber reported failure.	ceedlingEngine.ts	Cancellation is no failure.
Discovery in flight at disposal could show an error, and create watchers and a TestController, for a removed folder.	testController.ts	A disposed guard.
The test API reached every extension in production, including dispose().	main.ts	It is returned only in ExtensionMode.Test.
run() could create a TestController for a folder without a project.	testController.ts	It does nothing there.
The fake's --test-case was an exact match, unlike Ceedling's substring match, so the engine's rerun path went untested in VS Code.	fake Ceedling	Substring matching, plus an integration test of the rerun.
The Clean integration test could run before discovery finished.	extension.test.ts	It waits for discovery.
"Never runs Ceedling in a folder without a project" was claimed but unchecked.	integration	Both folders run the fake, and that folder must have no log.
Removing the temporary workspace could throw on Windows and fail a passing run.	tests/integration/main.ts	Retries, then a warning.
CI's coverage step hid failures behind tee.	ci.yml	shell: bash (pipefail).
npm test compiled the test build twice; clean left out-test/ and coverage/.	package.json	Fixed both.
Stale docs and comments: the debug executable layout from Ceedling 1.2.0, "build lock", "the engine serializes runs", and a test helper's comment.	various	Corrected.
Duplicated SourceEvent union.	testController.ts	Imports the type.
A failed ceedling files:test emptied the project silently. The project loaded with no test files. Shipped in 2.0.1.	ceedlingEngine.ts	Discovery fails with a CeedlingLoadError naming each project whose listing failed and the settings to check. The engine keeps its last good projects, as for every failed discovery. Added to the CHANGELOG.

Deferred, with reasons

• No integration coverage of the Debug profile (deferred by decision). It would need VS Code's built-in JavaScript debugger to start sessions reliably in CI on all three OSes. debugLaunch.ts is unit-tested, and the manual checklist covers debugging.
• One unbuildable marker among valid ones (e.g. a TEST_RANGE() without a range beside a valid one) still lists the valid marker's cases. The warning explains why they go unreported, as it already does for a zero step.

Reviewed and found sound

• Locking: no deadlocks or lock-ordering cycles; every Ceedling command except version holds its directory lock.
• Promises: no floating promises or unhandled rejections in src/.
• Extraction: it preserves behavior path by path.
• Lint-pass fallbacks: none of the ?? fallbacks can fire.
• lineAt: the binary search is equivalent to the old linear scan.
• Concurrency tests: they fail when the lock or the shared read limit is removed. A reviewer checked this by breaking the code on purpose.
• Docs: every symbol they name exists.

CI is green on Linux, macOS, and Windows. 356 unit tests and 14 integration tests pass.

🤖 Generated with Claude Code