Repository navigation
Conversation
upload-coverage.sh posted raw Clover XML to the Coveralls jobs API, which only accepts Coveralls JSON, so every upload was rejected while the script reported success. scripts/coveralls.sh runs the pinned official reporter instead. On develop, the build job uploads PHP coverage (flag php) and build-client uploads Vitest lcov coverage (flag client) as parallel jobs, and a coverage-done job closes the Coveralls build once both have run. It skips without COVERALLS_REPO_TOKEN or off develop, and fails if Coveralls rejects an upload. Point the README coverage badge at develop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets
nuxt-client(#898). The develop-side equivalent for PHP only is #947.What this does
scripts/coveralls.shuploads coverage with the official Coveralls reporter (pinned to v0.6.22):report php clover tests/clover.xml, from thebuildjob. Container paths (/var/www/) are made repo-relative.report client lcov client/coverage/lcov.info client, frombuild-client. Vitest now runs with--coveragethere.done, from a newcoverage-donejob that runs on develop afterbuildandbuild-clientand closes the build.phpandclientin one Coveralls build (keyed on the CircleCI workflow id), so the README badge shows combined coverage.COVERALLS_REPO_TOKENand fails the job if Coveralls rejects an upload.docker:test:phpunitno longer uploads;upload-coverage.shis removed. It posted raw Clover XML to an endpoint that only accepts Coveralls JSON, so every upload was rejected while the script printed success.develop.When develop is next merged into
nuxt-client, keep this version over #947'scoverage:uploadtask.Not in code
For a Coveralls status check on PRs, enable the Coveralls GitHub integration for the repo on coveralls.io.