Restructure BAYS_AE - #141
Restructure BAYS_AE #141DCEW wants to merge 20 commits into
Conversation
There was a problem hiding this comment.
Changing the format of three of our key reference files from YAML to CSV is a decision that needs wider discussion before it is enacted in a pull request.
If we change them to CSV we'll need to update the pages that refer to them, e.g. calculation-traceability-matrix.md, classification-register.md and conversion-archetypes-catalogue.md. As it stands, your PR will break these pages.
YAML is arguably a better format because of the structure of the data. I'm sure it is also possible to load and filter the data from YAML format as well as CSV. I can take a look into this if you would like.
Welcome thoughts from @paulseamer on the preferred file format for these reference files
f6ed2f6 to
c36a9d0
Compare
|
Your code references |
Yes, I messaged Rhian about this as I can't render locally with Paul's formatting changes. |
|
My other initial thoughts (not full code review yet): We need to be more DRY as there are loads of these functional area pages - worth defining a function for loading and filtering the reference files that we can reuse for each of them? (This can be handled in a later issue/PR but worth considering before we start applying the changes in this specific PR to all the functional area pages) The way the files are filtered |
add info on exclusion of cardiac catheter and IR activity from theatres
|
Ok, I've gone back and altered the code that renders the assumptions table to make it more programmatically derived - avoiding the more brittle approach from before. Further DRYing out can be a focus for a future PR (I've made a new issue for it). NB the diff also includes the incoming changes from PS as I had to rebase (I think that's why anyway). |
Second attempt on this PR taking into account previous comments
Relates to #94
Closes #55
Previous PR is here - recreated entirely due to git issues.

