Repository navigation
fix(extension): avoid fetching nonexistent overlay CSS - #403
Open
KennyMcSimpson wants to merge 1 commit into
Open
KennyMcSimpson wants to merge 1 commit into
KennyMcSimpson wants to merge 1 commit into
Conversation
KennyMcSimpson
marked this pull request as ready for review
October 6, 2026 08:24
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #398.
The overlay CSS is already imported with
?inlineand supplied tocreateShadowRootUi. SettingcssInjectionMode: "ui"also makes WXT requestcontent-scripts/content.css, which the production build does not emit.Remove that setting and keep the existing inline stylesheet. The overlay continues to mount inside its ShadowRoot without the extra request.
Validation
pnpm ext:test: 2,421 passed, 122 skipped.pnpm --filter @browser-skill/extension compilepassed.pnpm lintpassed, including the plugin's 446 tests.A live Chrome smoke test could not run because this environment rejects Chrome's process-singleton socket creation. The bundle check does not cover browser rendering.