Conversation
Author
|
Thanks for the review opportunity. I’ve kept this PR intentionally focused on the FH-009 attack-path reporting gap and included regression coverage for the downstream sink. The branch is ready for review; I’m happy to adjust anything you’d like changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
FH-009 correctly detected an untrusted write into shared memory followed by a second agent reading that memory.
However, the reported path could stop at the reading agent even when a downstream target was already identified by the analysis.
This made the attack-path evidence incomplete and could obscure the final sink when reviewing a finding.
Fix
The rule now resolves the downstream path from the reading agent to the identified target and includes that path in the finding.
This preserves the existing detection logic while making the resulting attack-path evidence complete.
Tests
Added regression coverage verifying that:
Scope
Focused change to FH-009 path reporting and its regression test. No changes to unrelated detection rules or runtime behavior.