feature/teams - #29
Open
maxryan008 wants to merge 6 commits into
Open
maxryan008 wants to merge 6 commits into
maxryan008 wants to merge 6 commits into
Conversation
… for machine lib to use. Vanilla minecraft teams is the default however if a mod has a better team system and wishes to use it with machine lib they can now register their team system with machine lib and then machine libs config allows using that specific team system.
# Conflicts: # src/main/java/dev/galacticraft/machinelib/impl/config/MachineLibConfig.java
…to simplify usability.
Roelymole
reviewed
Sep 22, 2026
Roelymole
left a comment
Roelymole
left a comment
Member
There was a problem hiding this comment.
This looks like a really powerful feature.
# Conflicts: # src/main/java/dev/galacticraft/machinelib/impl/config/MachineLibConfig.java
Roelymole
reviewed
Sep 22, 2026
Comment on lines
+84
to
+85
| @Override @NotNull | ||
| public String teamSystem() { |
Member
There was a problem hiding this comment.
The convention in almost all of MachineLib is to put the annotation between public and String, so it is probably best to stick with that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a team registration system for other mods to use aswell as a base default team system that uses vanilla minecraft's scoreboard team command system.