feat: groundwork for oxygen detector - #27
Merged
Merged
Conversation
…MachineLib into groundwork/oxygen_detector
…MachineLib into groundwork/oxygen_detector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
ResourceType.OVERRIDEfor use in the side config tab to select which directions should be checked for oxygen, swapping between a texture with a grating to let the oxygen in and a plain face.The
faceHasOverridemethod should be overridden in theOxygenDetectorBlockEntityclass in order to return true for each face we wish to enable theResourceType.OVERRIDEfor, which is probably all 6 faces.The sides with the
ResourceType.OVERRIDEselected are always displayed as the blank machine faces, so a different texture for these faces should be provided in theGCModelProvider.