Skip to content

Draft security review R356: pinned cleanup and protected Helper recovery - #2

Draft
GOD13emad wants to merge 139 commits into
mainfrom
sync/personal-main-9960a06d-review
Draft

GOD13emad wants to merge 139 commits into
mainfrom
sync/personal-main-9960a06d-review

Conversation

@GOD13emad

@GOD13emad GOD13emad commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Current security review — production candidate R356, validated through R360

Exact PR head: f3a841856c6b7eeeec41beb464fc22af88e3aef8 (same in the personal and organization review branches). Status: scoped security review only, not merged and not published. The official, owner-installed v1.7.8 remains intentionally unsigned and unchanged. This review is AI-assisted technical evidence, not a claim of a named person's independent approval.

Accepted production change: the original Setup's deferred cleanup uses SetFileInformationByHandle(FileDispositionInfo) to delete verified empty directories via their still-pinned native handles, removing the previously observed release-to-path-delete window. The protected Helper's existing Broker/Supervisor leaf-identity and journal-recovery safeguards remain in place. The original 22,000-character PowerShell command guard was preserved.

Verified evidence (exact versions and scope):

  • R356 original compiled Setup tests: Windows 2025/2022, 8/8 nominal, root/child junction and live rename cases; 94 named checks, 8 GitHub archive ZIPs and 10 raw JSON SHA-256 matches, 27 hostile receipt mutants rejected.
  • R356 full Build/Verification: 3/3 successful.
  • R358 unchanged original PE Helper: 2/2 hosted Windows PREPARED journal cold recoveries with separate native symlink replacement attempts denied; original protected binary/task XML restored.
  • R360 unchanged original PE Helper: 2/2 hosted Windows PREPARED journal recoveries with real two-link hardlink MoveFileExW attempts denied (Win32 5); external file hashes preserved, 30 independent receipt mutants rejected. R360 Build successful. R358/R360 are test-only descendants, not additional unmerged product changes.
  • Project accepted evidence is recorded through R360. Previous manually compiled local-threat CodeQL findings were triaged within their source-to-sink scope; warnings were not dismissed.

Explicit remaining limitations: no exhaustive claim for all NTFS/cross-user races or all malware; real owner-visible secure-desktop UAC consent and actual physical Windows banner/speaker delivery are not independently witnessed. Issue #6 awaits the original reporter's flagged driver SHA-256 and download/installation origin; do not bypass Defender. Signing is intentionally waived for this release.

Decision: keep this PR in review; do not equate CI success with blanket security acceptance, a merged release or the already installed v1.7.8.


Historical R349–R355 review notes (retained for provenance)

Historical R349 exact embedded native leaf handle and original Helper regression (2026-10-19)

  • Reviewed but NOT merged: Both security PR heads are now exactly 46c896f123a98aa7fa234bd4b266c8003ebb621e, non-force fast-forward descendants of R347. The personal PR remains OPEN; organization PR Draft security review R356: pinned cleanup and protected Helper recovery #2 remains OPEN/DRAFT. Owner original unsigned v1.7.8 executable/Glass config, public release and protected main were not changed.
  • Bounded product repair: R348 had genuinely shown an already-Administrator second process could overwrite Broker leaf contents despite R347's pinned directory handles. R349 adds a native TBMEProtectedBrokerLease.OpenReplayLeaf using actual GENERIC_READ|GENERIC_WRITE and only FILE_SHARE_READ, with FILE_FLAG_OPEN_REPARSE_POINT, file-type/reparse/hardlink count and final-path checks. It retains each opened original snapshot leaf handle across PREPARED file write/readback, old task restoration and journal retirement. Restore writes and SHA rereads use the same exact handle, and preopens all original snapshot files before writing. Already-held DELETE access prevents new exclusive lease (fail closed). Compacting CSharp comments/indentation kept the original single in-memory PE resource and trusted RunAs command length limits intact; no user-writable script extraction, security bypass or new driver installation.
  • Independent native evidence: R349 already-admin Windows A/B 39257019395 2/2 SUCCESS, 8 checks each. A distinct administrator process's known protected-leaf overwrite was denied by real OS sharing; exact previous leaf bytes unchanged while open. A preopened DELETE-access handle refused subsequent exclusive replay-leaf open with Win32 error 32; after both handles closed, the test-owned file could be rewritten normally. Four typed parent/actor raw receipts independently SHA-256 checked (A parent F5E5CBEA/actor 7651D72E; B parent 9E224CB5/actor 81C90E43). Temporary ProgramFiles fixtures and canaries cleaned/checked.
  • Original complete production Helper: exact-source Windows 2025/2022 8-job regression 39257112602 8/8 SUCCESS nominal, early kill, post-task delete and post-Broker.exe delete. Post-mutation original Helper cold-restored exact binary/owner hashes, task principal/byte-exact XML and retired journal before final Uninstall. All 8 Helper + 8 ACL + 2 no-valid-journal typed receipts independently checked. Exact code full CI 39257019337 3/3 SUCCESS. Local four-component build, R334 24/24 and R335 23/23 passed. R349 F00 native test-only run 39256574218 was FAIL because harness missed an exact managed IOException with WIN32_32, corrected without product code change. Initial uncompressed CSharp triggered the established Setup command-line length limit, corrected by removing only CSharp comments/indentation (never relaxing the limit).
  • Open gates / scope: R349 locks original saved leaf files during replay, not every newly introduced file pending deletion, and only the isolated adversarial test used a concurrent second administrator while the real full Helper regression did not deliberately overlap a concurrent privileged writer. Already-open DELETE was demonstrated to fail closed in the native class; a full Helper cold-replay-under-that-handle witness, race on allowlisted new-file deletion and other privileged leaf/reparse swaps still need independent proof. Native interactive UAC consent, seven inherited CSharp command warnings (4 Supervisor, 3 Setup), physical Glass thermal Windows banner/speaker and Defender Issue fix(security): make sensor log/result asInvoker-owned via verified IPC (R080) #6 original reporter SHA/provenance remain OPEN. No merge, release or CodeQL dismissal authorized.

R347 actual Windows privileged directory-rename defense (2026-10-19)

  • Exact security source head 2e246134ddf5a3efcfa66900d6d97fc19167643f; both security PRs have been non-force fast-forwarded, remain OPEN / UNMERGED (organization PR Draft security review R356: pinned cleanup and protected Helper recovery #2 stays Draft). Original user-installed unsigned v1.7.8, Glass config, protected main, release and CodeQL alerts were not changed.
  • Root cause and scoped fix: the previous TBMEProtectedBrokerLease used FILE_READ_ATTRIBUTES which Microsoft documents as exempt from sharing restrictions; hostile privileged directory rename succeeded despite the handle. F01 requests FILE_LIST_DIRECTORY with FILE_SHARE_READ|FILE_SHARE_WRITE and no FILE_SHARE_DELETE, pins the real Program Files, protected product root and SensorBroker directory across hash-bound PREPARED journal replay and task restoration; uses one exact Setup-compatible native Add-Type here-string.
  • Actual disposable native proof: R347 Windows 2025/2022 test 39248307747 2/2 SUCCESS. Two distinct concurrent processes holding administrative tokens (not different accounts) ran on each host; the second process made 80 Broker plus 80 product-directory rename attempts, all 160/160 denied per host. While handles remained open, the parent validated the canonical pinned tree 109 times on A and 112 on B. After handle disposal, admin rename succeeded. A real NTFS junction was rejected by the compiled PE-embedded CSharp lease without touching the outside canary. Each host completed 8/8 typed checks; exact four parent/actor raw SHA-256 receipts independently downloaded, SID/Process ID and counts bound, and test-created protected fixtures removed.
  • Regression: R347 full Helper nominal, early-kill, post-task and post-Broker-deletion 39247474001 8/8 SUCCESS on Windows A/B with actual original PE-embedded Helper cold replay; exact R347 F03 full CI 39248307770 3/3 SUCCESS. Local full four-project Build plus native security command-sink R334 24/24 and user-log lease R335 23/23 passed. Earlier R347 experiments 39246502929 (attribute-only handle did not block rename) and 39247473885 (PS5.1 nested .NET sharing/junction exception was incorrectly interpreted by test harness) remain FAIL provenance, not promoted.
  • Residual acceptance is separate: genuine test blocked directory rename/reparse while pinned; it does not prove atomic identity of individual Broker leaf files, racing privileged leaf overwrite, or resilience to an already-open privileged DELETE handle. No physical interactive UAC consent was observed. Seven inherited manually compiled CSharp CodeQL command findings (4 Supervisor, 3 Setup) still require independent security adjudication; physical thermal toast/audio and external Defender Issue fix(security): make sensor log/result asInvoker-owned via verified IPC (R080) #6 reporter file provenance also remain open. No merge, public release, or dismissal of security findings.

Current supplemental security evidence — R345 serial privileged foreign-member refusal (2026-10-19)

  • Production review code remains exact R344 F08 ce33b95b859845d865e5bb90db5120fdf0ed129f; R345 cc85d570e18bf30a3cc226212b6884f940150e1f is a distinct test-only branch with no additional product change. Both PRs remain unmerged (organization PR remains Draft), and official unsigned v1.7.8 and owner Glass settings are unchanged.
  • Original PE-embedded Helper privileged unknown-member native Windows A/B run: 2/2 PASS, 14 typed checks per guest, both independent raw SHA-256 receipts verified. An already-admin disposable actor injected a test file into protected Broker after the actual Helper was killed following Broker.exe deletion; real Helper refused cold replay with DEGRADED_ROLLBACK_RECOVERY_REQUIRED, preserved the unexpected file and PREPARED journal. After the exact test-owned file alone was removed and hash checked, identical Helper restored prior owner, Broker/Supervisor binaries and Task XML, retired journal, and final Uninstall succeeded. Exact-head full CI 3/3 PASS.
  • Limit: This proves fail-closed behavior against a serial unexpected privileged filesystem write, NOT simultaneous privileged reparse/rename race atomicity or real interactive UAC consent. Seven inherited manual CSharp CodeQL command findings (4 Supervisor, 3 Setup), physical warning/audio witness, external Defender Issue fix(security): make sensor log/result asInvoker-owned via verified IPC (R080) #6 reporter SHA/origin and independent security approval remain OPEN. No release, merge or alert dismissal is authorized by these tests.

CURRENT Draft security review — protected SensorBroker uninstall PREPARED journal (2026-10-19)

  • Exact source head ce33b95b859845d865e5bb90db5120fdf0ed129f, safe fast-forward from R338 ce91a0328e4af353e7e77ed227b9900327e82e76, with only bounded installer Helper and native security test/workflow changes. Remains DRAFT / OPEN / UNMERGED. Neither repository's protected main, official unsigned v1.7.8 Release nor maintainer's installed Main/Glass config changed.
  • Concrete defect and mitigation: R343 original Helper post-Broker.exe kill failure 39223363336 left a markerless protected root after interrupted deletion. Production R344 creates an authenticated, admin-owned exact protected-file SHA/SID and Task XML PREPARED durable journal before first Uninstall mutation; on cold entrypoint it verifies same owner from snapshot and actual effective token, replays byte-exact files and Task policy, and retires the journal before any subsequent removal. Root causes included a composite FileSystemRights.Modify read-vs-write mask and PowerShell 5.1 nested script-local/$script: rollback state shadowing. Both fixed, temporary debug logging removed, broad untrusted markerless-root deletion not permitted.
  • Accepted native evidence: final 8/8 original-PE Helper Windows 2025/2022 matrix 39236025913: nominal, pre-mutation kill, post-task deletion kill, post-Broker binary deletion kill, each A/B succeeds. Post-mutation original Helper first cold-restores exact Broker/Supervisor/owner SID marker SHA and exported Task XML/principal/action; third exact original Helper exits 0 after UNINSTALLED. Eight actual admin-ACL test receipts (6 checks each) reject four mutations but permit ordinary Users read/execute; two true original Helper negative guests reject both markerless without journal and foreign SID without journal, preserving unrelated files. All 18 raw typed guest receipts independently checked for exact commit and SHA256. Reproducible Setup SHA256 21745837189E8897BC77877EC312CE087C04A98846CDFC5297BD3C4AD8383B38.
  • Exact-head checks: candidate full CI 39236026025 3/3, personal security PR CI 39236700676 3/3, organization Draft PR CI 39236732075 3/3; organization CodeQL Analyze (csharp) 39236724810 PASS in separate default configuration. Prior manual four-project cs/command-line-injection results still have 4 Supervisor and 3 Setup unadjudicated sources, no alert dismissal or waiver.
  • Remaining independent security DoD: native interactive UAC approval of actual elevated helper (not available on already-admin hosted VM), concurrent malicious privileged writer/reparse race, physical Windows thermal OS notification/speaker, external Issue fix(security): make sensor log/result asInvoker-owned via verified IPC (R080) #6 reporter driver SHA/origin, independent security review. Do not merge, publish a replacement Release or claim FINAL from these bounded results.

Real original Helper run and kill-before-mutation — bounded Windows A/B evidence (2026-10-19)

  • Exact organization security production head remains ce91a0328e4af353e7e77ed227b9900327e82e76, OPEN/DRAFT/UNMERGED; no product-source or protected main change. Test-only GitHub branch audit/r340-real-helper-uninstall-death at b992c4e13770a5a08c281c5f433bb13edf45a9b3 changes only a native test and its hosted workflow. Both official unsigned v1.7.8 and owner's installed Main/config untouched.
  • R340/R341 four native Windows guests 39218769937 4/4 SUCCESS: Windows 2025 and 2022 each tested a disposable already-admin RunAs execution of the exact unmodified Setup PE-embedded full Sensor Helper against a newly created admin-owned protected Program Files sensor tree and disabled globally named Task. Nominal R340 A/B 9 checks each, original Helper ExitCode=0, expected UNINSTALLED result, task+Broker+test fixtures removed. Early-killed R341 A/B 10 checks each, real original Helper terminated after verified BEGIN mode=Uninstall, while exact original Task and protected binary hashes still intact; identical production RunAs process factory with a fresh different PID then completed uninstall/cleanup, ExitCode=0. Real guest typed receipts all independently SHA256-checked, four distinct variant/host IDs. Full current test-head CI 39218769924 3/3 SUCCESS.
  • Failure lineage: earlier R340 test-only runs 39216484416 and 39217108563 failed account principal/SID and PowerShell 5.1 Reflection marshalling. First R341 four-case run 39218420796 had the operational checks but the typed receipt failed casting SwitchParameter to Int32. All failures preserved and superseded by the corrected 4/4 native rerun, not silently relabeled PASS.
  • Security acceptance still OPEN: Hosted runner was already administrator, with no real UAC consent prompt; crash was before any protected task/files mutation, not an after-PREPARED journal/torn-write cold restoration. No attacker with privileged concurrent rename/reparse capabilities was tested; earlier real nonadmin cross-SID protection is a separate narrow gate. Seven inherited CodeQL command findings, independent Other-Owner review, physical thermal warning/sound and Defender reporter driver provenance remain pending. No override of OS UAC, sensor driver install, code scanning dismissal, merge, public publish or owner protected sensor mutation.

Earlier R339 real second-user protected Program Files evidence — organization Draft remains R338 code (2026-10-19)

  • Exact production review head unchanged: ce91a0328e4af353e7e77ed227b9900327e82e76; R339 78f60a99c6bf0c5ba63848245196756d521b765d is an additional test-only branch commit, no product code edits. Both security PRs stay OPEN / UNMERGED, organization PR Draft security review R356: pinned cleanup and protected Helper recovery #2 stays DRAFT. Protected main refs, original official unsigned v1.7.8 and owner's installed Main/Glass config were not mutated.
  • Genuine Windows 2025/2022 two-account test 39213817332 2/2 SUCCESS. Hosted admin created exact short-lived admin-owned Program Files/TaskbarMonitorEnhanced/SensorBroker fixture with reviewed compiled executable SHA. A freshly created true nonadmin account with distinct SID attempted seven classes of protected changes 60 times each: 420/420 denied per guest. Concurrent in-memory production TrustedWorkerPaths guard passed 32/51 checks. Protected binaries and outside canary unchanged, temporary test account/Program Files/ProgramData fixtures independently removed, raw typed SHA-256 receipts read back. Full test-branch CI 39213817390 3/3 SUCCESS. Failed earlier Harness runs with receipt masking, build-only LocalAppData scratch, account-description length and nullable ExitCode were corrected and never accepted as PASS.
  • Not a whole security verdict. Hosted runner already had administrator privileges and no actual native UAC consent occurred. No original elevated Helper was killed or restored, no simultaneous administrator writer/reparse exploit was exercised, and no account-wide security test beyond this exact isolated fixture was claimed. The manually compiled CSharp CodeQL baseline/candidate still has 113 findings each, including four Supervisor and three Setup command-line warnings, unchanged fingerprints; organization CodeQL PASS under its different query configuration is not closure. Independent Other-Owner review, physical user audio/toast and external Defender Issue fix(security): make sensor log/result asInvoker-owned via verified IPC (R080) #6 evidence still required before merge/release.

R338 organization security Draft code candidate — (2026-10-19)

  • Exact head: ce91a0328e4af353e7e77ed227b9900327e82e76, non-force reviewed descendant of R337 997c6f349fa64cfe6385113a9ede46d35479cc7a. Production candidate edf2610c20789028050b3ea76b1bee01c77d07bf, later test-only CodeQL workflow. PR remains DRAFT / OPEN / UNMERGED, independent Other-Owner security approval pending; protected personal and organization main and official unsigned v1.7.8 retained.
  • Scoped fix: compiled protected Supervisor previously constructed child Broker command directly from untrusted --broker and --output CLI strings, ignoring extra argv tokens. R338 accepts only one exact --broker/--output pair, verifies trusted fixed protected Program Files Broker and canonical same-account LocalAppData output, checks reparse ancestry and creates child path values from OS known folders rather than those argv strings. No real elevated Supervisor, UAC or machinewide task used in the isolated tests.
  • Native evidence: R338 Windows 2025/2022 four-host-variant matrix 39178809907 4/4 SUCCESS; 3 baseline checks per host reproduce prior unsafe parser acceptance, 12 hardened checks per host reject forged path, option and genuine junction with external canary unchanged. All four typed raw receipts independently downloaded, SHA256 checked and bound to exact baseline/candidate commits.
  • CI and CodeQL: Personal candidate CI 39178809877, personal test-head CI 39179087616, personal PR head CI 39179699954, and organization exact-head CI 39179708389 3/3 each. Organization CodeQL Analyze 39179706373 and PR CodeQL status PASS under the organization's separate configuration. Independent manual four-project CSharp CodeQL 39179087768 found 113 total in both, 15 inherited command-line findings including four Supervisor and three Setup, zero new/removed primary fingerprints and zero compiler errors. The latter are NOT security-adjudicated by a separate organization PASS.
  • Required before merge: independent actual interactive high-integrity UAC Helper crash/recovery, shared Program Files cross-user TOCTOU tests, retained command alerts security analysis and other-Owner review, OS/speaker witnessed warning, and outside reporter Defender driver origin. No CodeQL suppression/dismissal, protected main change, release, or maintainer host sensor mutation.

Historical organization security Draft — R337 (2026-10-19)

  • Exact head: 997c6f349fa64cfe6385113a9ede46d35479cc7a, non-force fast-forward of R335 fa57ae2c89304974f4b91d5a9ca7c3d5b06f57e1. This PR stays DRAFT / OPEN / UNMERGED. The organization's protected main, personal main, immutable public unsigned v1.7.8 and owner installation/config are unchanged.
  • R337 scope: On first-ever protected SensorBroker installation, process death after writing new files but before committing the PREPARED journal could leave an empty, SID-less Program Files BrokerRoot after replay. A future repair then refuses the orphan. The patch conditionally deletes only verified empty allowlisted directories non-recursively after prior-file hash/replay; unknown/reparse paths continue to fail closed.
  • Raw evidence: Four Windows 2025/2022 A/B differential jobs 4/4 SUCCESS and ten named checks each, proving the old behavior twice and fixed behavior twice in disposable admin-ACL sandbox roots. Raw receipts independently SHA-256-validated. The initial FAIL at 39175990570 was a test harness split-checkout receipt path, fixed by F01; never counted as PASS. Personal candidate 3-job CI, personal review 3-job CI and organization exact-head 3-job CI all SUCCESS. Organization CodeQL Analyze and PR CodeQL status PASS under organization configuration; three local-threat Setup command warnings from separate manual CSharp analysis are not adjudicated by this PASS.
  • Still not independently accepted: interactive true UAC/high-integrity original Helper kill/recovery; simultaneous protected ProgramFiles cross-user rename/reparse races; actionable security adjudication, owner physical banner/speaker and external Defender reporter proof. No forced ref change, CodeQL suppression/dismissal, merge, publish or owner-side protected sensor modification occurred.

Historical R334 snapshot — hosted security candidate at exact HEAD (2026-10-18)

Historical R334 review scope: At the time this was a DRAFT, OPEN, UNMERGED PR; reviewed head c134f5f, protected organization main 03e7078. The personal authoritative main is now c067129 (the R298 personal head in the historical body is superseded). The latest R334 commit changes only the CI workflow and a PowerShell negative contract test for three Setup command sinks; historical fixes on earlier candidate commits are retained.

Exact-current-head hosted checks: Build and Verification run 39163698546 completed SUCCESS with build plus R324 Windows negative A/B jobs (3/3). Dynamic PR run 39163696710 completed SUCCESS. GitHub check-run REST confirms 5/5 at this SHA: build, Analyze (csharp), CodeQL, and both Windows R324 negative jobs.

Scoped CodeQL: The authenticated Code Scanning API currently returns zero OPEN alerts for refs/pull/2/head, and the latest successful PR-ref CodeQL analysis names this exact head with an empty analysis error field. The protected main remains unchanged and currently has 215 OPEN alerts (17 Critical / 198 High) by independent paginated readback. PR-ref zero does NOT close main branch alerts or prove exploitability, full code quality, or production safety. No scanner alert was dismissed or suppressed.

Real remaining safety gates: Independently review native Windows high-integrity Helper/UAC and cross-user ownership, signed binary provenance, updater/rollback and power-interruption, non-atomic filesystem races, and source-to-organization commit/protection constraints before taking this candidate out of Draft. Genuine independent other-Owner security review is still required; CI/CodeQL does not substitute for it. No protected main, stable installer, release, or actual owner device has been changed by this PR update.


Historical R298 and earlier snapshots (preserved evidence, not current SHA/status)

Historical organization security Draft — R298 (2026-10-17)

  • Exact source and scope: 6b38199821652515c5c0f0d13952be687d4c333d, non-force security-review descendant of R297. Organization protected main 03e70785529354f741d75449a19d7e2538c2b81d and personal protected main 9960a06dba606d1c93b8ca2b84e0e3e25ca4f68d remain untouched. Official unsigned immutable v1.7.8 is installed with identical owner Main/config. This PR stays Draft and unmerged.
  • R298 mitigation: previous powershell.exe with ShellExecute runas had unqualified executable lookup; Microsoft documents searches involving the current working directory and PATH. The optional high-integrity Helper launch now uses the absolute system-owned Environment.SystemDirectory/WindowsPowerShell/v1.0/powershell.exe, rejecting any reparse component, and fixes the working directory to the same OS-owned location. Existing encoded-only Helper, no Temp PS1/PawnIO execution and prior payload/rollback protections remain.
  • Functional and negative evidence: full personal Build and visual CI 39023857203 SUCCESS; native Windows 2025/2022 39023632894 3/3 SUCCESS. Independently validated host receipts show 12/12 R298 checks each, including CWD/PATH named-file decoy ignored in the non-elevated ProcessStartInfo factory, explicit system executable for Install/Uninstall, unchanged runas and bounded -EncodedCommand, and preserved installed Main. Native tests intentionally never invoke UAC or protected sensor services.
  • Exact CodeQL: analysis 1972442411 FAILED with 11 High, ten C# cs/path-injection and one cs/command-line-injection, identical primary fingerprints to R297 1972389031. Setup is asInvoker, and these paths originate at the OS LocalAppData known folder; no alert is automatically dismissed as a false positive without threat-model evidence. Separate unresolved acceptance gates: real elevated/cross-user flow, non-atomic filesystem races, unsigned PE origin and memory-only rollback's loss after Helper process termination. No scanner suppression/dismissal, merge or public publication before independent security review.

Purpose

A review-only, exact-SHA pinned candidate for reconciling the organization's first-party public fork with the original personal upstream. This draft does not authorize release, signing, updater endpoint changes or force updates.

Exact comparison inputs

  • Organization main: 03e70785529354f741d75449a19d7e2538c2b81d.
  • Personal upstream GOD13emad/TaskbarMonitorEnhanced:main: 9960a06dba606d1c93b8ca2b84e0e3e25ca4f68d.
  • The candidate branch sync/personal-main-9960a06d-review was initially pinned to that personal source SHA. It was historically non-force fast-forwarded to 486abbbbf7d1c50097113d77c8f00ee13b393c09, and is now on R290 4666b87fbe4b548304522a2a4d45d8db6ee41184 (the same extra security-fix commit proposed in personal source PR #80). The original personal main remains at 9960a06d... pending review; the candidate is not currently identical to released upstream main.
  • Original source-to-org GitHub compare: 19 source-ahead commits. The historical R052 organization draft at SHA 486ab... was 20 ahead, 0 behind, 70 changed files; current R290 comparison is reported above. Merge base equals org main. The changed set includes Windows installer/monitor code and GitHub Actions workflows, including an older workflow removal.

Historical R053 CodeQL data-flow on R052 — nine findings (superseded head)

CodeQL reran on updated candidate 486abbbbf7d1c50097113d77c8f00ee13b393c09 and again reported nine High cs/path-injection findings: failed check. Downloaded authorized SARIF (1970888296) traces their common source to the per-user Windows known-folder call Environment.GetFolderPath(SpecialFolder.LocalApplicationData) used by AppRoot, then UPath, not to the index string already checked against the static UpgradeTargets allowlist. The R052 one-file hardening remains present but is not an accepted CodeQL remediation.

Before taking this draft out of review: assess actual Windows per-user installer threat boundaries (canonical-root containment, junction/reparse checks and sensor elevation), demonstrate relevant positive/negative runtime tests, and remediate any exploitable crossing. If the findings are false positives, document a verifiable case and have an independent authorized human reviewer decide; do not dismiss nine findings solely for CI success. The candidate is not security-accepted.

R052 path-allowlist security fix and current CI status

  • The first CodeQL check on the unpatched PR draft head reported 9 new High path-expression alerts in the installer upgrade/rollback Journal. The code checked on-disk journal labels against the fixed UpgradeTargets list but passed the original disk text onward. This candidate now passes the compile-time allowlisted target name into StageEntry after the equality validation, without changing the expected journal layout or rollback rules.
  • Independent exact-commit temporary Windows testing on the proposed personal source fix 486abbb...: one-file diff, whitespace check, path-binding contract and three offline synthetic host-witness/signing/publication contract suites PASS. Installed Windows updater, actual signed setup, lab power interruption, security acceptance and production release NOT tested or claimed.
  • Required new evidence: Read and evaluate the fresh CodeQL check for this updated draft head. Do not claim the 9 High findings resolved until the new scan actually confirms it. A clean candidate scan would not prove closure of the existing 17 Critical findings on protected organization main.

Required acceptance gates

  1. Review Windows native build, sensor/PawnIO guard behavior, installer and updater regression, rollback/recovery, maintenance, signer/package provenance and exact-HEAD CI. A successful code fetch alone is not an acceptance test.
  2. Note 17 currently reported Critical CodeQL entries in the organization main, all in command-line-injection analysis. Determine each candidate's relevant status, remediate genuine issues and verify on actual post-merge main; do not simply dismiss alerts.
  3. Wait for separately reviewed organizational collaboration and fork protocol proposals #3 and #4. Obtain a genuine independent other-Owner review of this candidate and recheck branch rules / exact SHAs before any merge.
  4. Preserve the personal original's official Releases/updater continuity; no automatic release or signing changes.

Status: DRAFT / NOT MERGED / NOT RELEASED; no private data or protected default-branch ref modified.

TBME Audit and others added 19 commits October 16, 2026 00:12
)

Adopt exact 5-line source-only R190 geometry-first CPU path after same-host owner 4x60s ABBA verification and independent hosted native A/B checks. Immutable public v1.7.2 and owner installation remain unchanged. Owner Search/Start real UI and external security/hardware gates remain open.
Exact PR head Build and Verification 38815309902, push build 38815244008 and real Windows A/B official v1.7.2→v1.7.3 protected upgrade/native 38815243928 SUCCESS. R244 nine settings pages + five proportional DPI model sweeps had zero control collision. R245 v1.7.2 atomic journal previous-version guard repaired and independently regression-tested. No v1.7.2 release/tag mutation; distinct v1.7.3 publication gated by main-head acceptance.
…D13emad#70)

Exact R256 versioned candidate  e7904d0: Build and Verification 38827688365 SUCCESS; Native and real Windows A/B 1.7.3 fresh+upgraded in-place acceptance 38827688310 SUCCESS; pull-request exact-head clean-clone Build 38862828329 SUCCESS. Future distinct immutable release still requires postmerge exact-head CI and public SHA256 provenance. Do not modify public v1.7.3 assets.
…OD13emad#71)

Exact R265 versioned source a9415ce: Build 38898619702 SUCCESS; real Windows A/B official v1.7.4 upgrade/fresh/native rollback 38898619873 SUCCESS; actual cross-account sensor guard 38898619854 SUCCESS; PR clean-head build 38899289789 SUCCESS. Distinct immutable public release withheld until exact merged-main CI, 7-asset SHA staging and independent G16 verification. Old v1.7.4 preserved.
Sanitized public status, preserve historical records, and keep security/physical/multiuser limitations explicit. CI build/verification run 38911429257 PASS.
R272 glass red warning fix. R273 exact versioned upgrade and dual hosted Windows native gates. R274 interrupted journal accepts official 1.7.5 rollback. Exact candidate A/B + Build CI pass. Preserve unsigned scope and Issue #6 open.
Redacted Current Project R276, current public Brain header and README updated. Immutable official v1.7.6 source and assets stay unchanged; exact historical Brain suffix preserved. Owner Glass red warnings and native Win A/B passes documented; Issue #6, real AC loss and machinewide-singleton limitations remain explicitly open. GitHub docs-branch full workflow 38937978453 SUCCESS.
Two exact-source GitHub-hosted Windows guests PASS on pinned 22-file v1.7.5 predecessor fixture and immutable v1.7.6 Setup cold recovery. PREPARED and COMMITTING (two managed file replacements) both real staging-helper process-kill, followed by successful normal installer /update /quiet, data preservation, one root and journal cleanup. Success CI 38954292153, PR full CI 38954753014. Not real AC loss or killed Setup. Initial failing harness executions retained as evidence; PowerShell reserved $args was fixed; no application binary, installer, driver or release change.
Actual v1.7.6 Setup crash left a partial .tbme-upgrade/old/Main.exe.restore; cold retry exited 34. Version 1.7.7 verifies exact owned journal then removes only known updater scratch and resumes using SHA-pinned previous snapshots. 22 exact previous official v1.7.6 managed SHA pins, one per-user root, new versioned readme/notes, no kernel driver or owner data mutation. Private source-head Build 38964870457 SUCCESS 3/3 including actual Setup kill on hosted B and deterministic abandoned scratch on A; PR general 38964979567 SUCCESS 27/27. Keep previous official immutable v1.7.6; current versioned test workflow runs on merged main. Physical AC loss explicitly excluded by owner; reporter issue #6 remains pending.
Existing public Index, Brain and Knowledge redacted summaries updated in place. Historical engineering records preserved, v1.7.7 immutable and real one-root owner update confirmed. Physical AC testing excluded at owner request; reporter Issue #6 and live OS notification audio remain externally unverified. No binaries or release files modified.
Sound remains disabled by default, uses user Windows Exclamation scheme only after real temperature threshold crossing with existing cooldown/quiet-hour gates; manual preview safe without heating. Exact SHA pinned 22-file v1.7.7 predecessor and native Setup recovery preserved. PR CI 38976966511 success, all 3 hosted native Windows jobs 38976887960 success. No driver, public release, machinewide singleton or owner install mutation.
@GOD13emad GOD13emad changed the title Draft: R338 security review with R339–R341 Windows acceptance evidence Draft security review R344: protected sensor rollback and genuine Windows evidence Oct 19, 2026
@GOD13emad GOD13emad changed the title Draft security review R344: protected sensor rollback and genuine Windows evidence Draft R344 security review: R345 protected foreign-file refusal proof Oct 19, 2026
@GOD13emad GOD13emad changed the title Draft R344 security review: R345 protected foreign-file refusal proof Draft security review R347: pinned Program Files Broker directory Oct 19, 2026
@GOD13emad GOD13emad changed the title Draft security review R347: pinned Program Files Broker directory Draft security review R349: protected leaf handles and PREPARED recovery Oct 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Engineering evidence review (submitted by the connected GitHub account; not a claim that Emad or Mohammad personally reviewed). Exact R349 production security head 46c896f is unchanged in independently tested R350/R351. Hosted Windows 2025/2022: R350 39267914762 (2/2), R351 39308062378 (2/2, 15/15 native checks per guest), Build 39308061773 success; SHA256-verified guest archives/raw receipts and independent negative-mutant checks confirm a separate already-admin process's GENERIC_WRITE access-open was refused with Win32 32 while the original compiled Helper and PREPARED journal were active; exact old protected bytes, task XML and cleanup recovered. This is scoped acceptance of native open exclusion, NOT full security acceptance. Open: active reparse/hardlink substitution, actual hostile overwrite/atomicity, interactive UAC, manual adjudication of inherited command-line findings, external Defender issue #6 attribution and owner physical audio/banner. Do not merge or publish until relevant outstanding security gates have their own reproducible accepted evidence. CodeQL/build check success alone does not close those gates.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-assisted scoped technical review via the linked GitHub account (not a personal assertion of human review).

R353: Independently downloaded the actual manually compiled R346 C# CodeQL SARIF from run 39240588189, verified SHA256 baseline CBF51372... and candidate 337D9BFD..., and traced seven unchanged cs/command-line-injection sinks (Setup lines 399, 718, 1239; Supervisor 654, 655, 1005, 1006) to all first-hop source locations. All Setup/Supervisor/Broker/Main C# blob IDs are byte-identical between manual-CodeQL source ce33b95, this PR's 46c896f, and R352 test head 79d1967; independent validator rejected 19 altered source/SARIF fingerprints. Setup uses a PE-embedded trusted PowerShell bootstrap with allowlisted mode and UTF8/Base64 data, an exact SHA-pinned Main FileStream with no-argument non-shell CreateProcess, and fixed native PowerShell UTF16 EncodedCommand deferred cleanup. Supervisor reconstructs protected Broker and fixed output paths from Windows special folders after exact argv validation; caller argv is not directly forwarded. Accepted native R334 (24 checks/Windows host) and R338 (12 checks/host) continue to apply under unchanged C# bytes. Scoped source-origin attribution review CLOSED; all seven local-threat manual warnings still exist in SARIF and none is suppressed/dismissed.

R352 original PE Helper also passed real protected hardlink/symlink refusal on Windows 2025/2022, 4/4 jobs at run 39315873039, with journal recovery and outside target hashes preserved.

Not security-FINAL or approval to merge: manual local-threat classification is not a proof against same-user ancestor/path swaps, privilege-boundary races or actual interactive secure-desktop UAC consent. External Issue #6 driver origin/SHA and physical owner banner/speaker evidence remain unverified. The official v1.7.8 remains unchanged. Please preserve the distinct remaining acceptance gates; this review does not represent Mohammad/Emad personal approval and is a COMMENT, not APPROVE.

@GOD13emad GOD13emad left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-assisted review via the linked GitHub account, not a personal human attestation. PR #2 was fast-forwarded (no force) to the same SHA as the personal security PR GOD13emad#80: f3a8418. Reviewed R356 real production Setup's pinned-handle directory disposition: 8/8 disposable Windows 2025/2022 original compiled-PE guest jobs passed Nominal, RootJunction, ChildJunction, LiveRace (94 named checks); 8 archive and 10 raw JSON hashes were independently verified; 27 malicious receipt mutations rejected. Native Win32 prototype 39334431901 passed A/B; owner installation and immutable unsigned v1.7.8 unchanged. GitHub full Build and Verification succeeded on original head (39336379393), personal PR CI (39338293952), and organization PR CI (39338309633), all 3/3. Organization CodeQL PR #2 39338306449 passed. Scoped native source change accepted locally in project control R356 commit 4e4179b. This is COMMENT, not APPROVE or evidence that all security gates are closed. Remaining true interactive secure-desktop UAC, privileged protected Broker leaf concurrent reparse/hardlink identity race, physical Glass OS notification/audio and external Defender Issue #6 reporter SHA/origin are separate acceptance requirements. Preserve Draft and do not merge/publish until the remaining consequential gates are validated.

@GOD13emad GOD13emad left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-assisted, evidence-scoped update for the existing review; not a claim of personal review by named people and not an unconditional APPROVE. Production PR #2 remains pinned to f3a8418, identical to personal PR GOD13emad#80. R358 test-only head a481af7 kept the production Setup and Helper exact Git blobs unchanged. Windows A/B real original PE Helper PREPARED cold recovery plus simultaneous separate already-admin native symlink MoveFileExW swap: 2/2 PASS (39343228831), 15 native checks per guest, Win32 5 denied during Helper live PREPARED journal; byte-exact protected Broker/Supervisor/owner and disabled task principal/XML restored, journal retired, third original Helper finalized uninstall. GitHub raw ZIP and JSON SHA independently matched; project verifier rejected 26 hostile mutants, secondary independent QA rejected 19. Full Build 39343228743 3/3 PASS; project authoritative scoped acceptance R358 commit fcff314. This does NOT close true interactive secure-desktop UAC, exhaustive NTFS/cross-user races, physical Glass OS banner/audio, or Issue #6 reporter WinRing0 SHA/origin. Original installed/official unsigned v1.7.8 unchanged. Keep Draft and do not merge or ship on the assumption these external limitations have been independently accepted.

@mohammadmohammadzadeh19960-code mohammadmohammadzadeh19960-code changed the title Draft security review R349: protected leaf handles and PREPARED recovery Draft security review R356: pinned cleanup and protected Helper recovery Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants