fix(db): unify ordered window semantics - #1778
Open
KyleAMathews wants to merge 99 commits into
Open
Conversation
…t-total-order # Conflicts: # packages/db/src/query/effect.ts
…et-total-order # Conflicts: # packages/db/src/collection/subscription.ts
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…to codex/loadsubset-total-order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TotalOrderfor query execution, cursor boundaries, source refinement, and public-key tiesWindowStateso offset/limit changes and SSE updates cannot widen from unproven rowsWhy
Lazy ordered queries previously used different order and coverage rules at each layer. A source page could look complete to one layer while the live query still lacked a tied row, or a later window could reuse a boundary that did not prove its prefix. This made results depend on request shape, event timing, and index direction.
This PR makes the applied row receipt the source of boundary provenance and uses the same total order from acquisition through publication.
Validation
Stacked on #1774. Advances the TotalOrder/window-state step of #1657.