refactor(migrations): sqlalchemy be gone

src/tagstudio/core/library/alchemy/constants.py

@@ -39,13 +39,18 @@
 """)
 
 
-DEFAULT_FIELD_TEMPLATES = (
-    TextFieldTemplate(name="Title"),
-    TextFieldTemplate(name="Author"),
-    TextFieldTemplate(name="Artist"),
-    TextFieldTemplate(name="URL"),
-    TextFieldTemplate(name="Description", is_multiline=True),
-    TextFieldTemplate(name="Notes", is_multiline=True),
-    TextFieldTemplate(name="Comments", is_multiline=True),
-    DatetimeFieldTemplate(name="Date"),
+DEFAULT_TEXT_FIELD_TEMPLATES = (
+    {"name": "Title", "is_multiline": False},
+    {"name": "Author", "is_multiline": False},
+    {"name": "Artist", "is_multiline": False},
+    {"name": "URL", "is_multiline": False},
+    {"name": "Description", "is_multiline": True},
+    {"name": "Notes", "is_multiline": True},
+    {"name": "Comments", "is_multiline": True},
 )
+
+DEFAULT_DATETIME_FIELD_TEMPLATES = ({"name": "Date"},)
+
+DEFAULT_FIELD_TEMPLATES = [TextFieldTemplate(**p) for p in DEFAULT_TEXT_FIELD_TEMPLATES] + [
+    DatetimeFieldTemplate(**p) for p in DEFAULT_DATETIME_FIELD_TEMPLATES
+]

src/tagstudio/core/library/alchemy/library.py

@@ -504,20 +504,19 @@ def open_sqlite_library(
     ) -> LibraryStatus:
         logger.info("[Library] Opening SQLite Library", library_dir=library_dir)
 
-        self.engine = self.__get_engine(library_dir, in_memory, sql_filename)
-
+        # migrate if necessary
         try:
-            migrations = DBMigrations(library_dir, self.engine)
-
-            # save backup if patches will be applied
-            if migrations.required:
-                Library.save_library_backup_to_disk(library_dir)
+            with DBMigrations(library_dir, sql_filename) as migrations:
+                # save backup if patches will be applied
+                if migrations.required:
+                    Library.save_library_backup_to_disk(library_dir)
 
-            migrations.run()
+                migrations.run()
         except MigrationError as e:
             return LibraryStatus(success=False, message=e.args[0])
 
-        # everything is fine, set the library path
+        # open up-to-date library
+        self.engine = self.__get_engine(library_dir, in_memory, sql_filename)
         self.library_dir = library_dir
         return LibraryStatus(success=True, library_path=library_dir)