fix(datagrid): value-filter popover value font and row alignment - #2580
Open
shreeve wants to merge 1 commit into
Open
fix(datagrid): value-filter popover value font and row alignment#2580shreeve wants to merge 1 commit into
shreeve wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The column value-filter popover renders its distinct values in the system font instead of the Data Grid Font, and its value rows sit at a different left edge than the Select All row above them, so the two checkbox columns do not line up.
Root cause
The value
Textcarried no font modifier, so it fell back to the system face. That is the #2393 defect class: it looks right only while the user leaves the Data Grid Font at the default, so it ships invisibly. The alignment gap comes from two owners of the left edge: the Select All row is padded.horizontal, 14while the value rows keep the plainListstyle's default row insets.Fix
ThemeEngine.shared.valueFontSwiftUI, the same way every other value-rendering popover does. The occurrence count keeps.callout.monospacedDigit(); it is metadata, not a stored value.horizontalInsetconstant now owns the left edge, consumed by the header, the controls row and the value rows'.listRowInsets, so the columns cannot drift apart again. Same patternColumnVisibilityPopoveruses for its rows.Tests
ColumnValueFilterPopover.swiftadded toValueFontTests.standaloneValueViewsResolveTheValueFont, the source-scanning guard that fails when a value-rendering view stops resolving the value font. Suite passes (7 tests). The alignment itself is a shared-constant layout fact with no deterministic UI-test surface; the popover needs a live connection and a loaded column to open.