Repository navigation
[BUGFIX] Fix PHPStan errors - #810
Merged
Merged
Conversation
PHPStan now checks Prophecy stubs against the real method signatures, so argument tokens in tests became type errors and six baseline entries stopped matching. Tokens are replaced by plain values where possible, the remaining wildcards in FactoryTest get an identifier-based ignore, and RollbackTask drops a sort flag PHP never applied. No behaviour change.
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the PHPStan errors that currently break CI on every PR (e.g. #809). No behaviour changes.