Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTPAgent currently disables certificate verification for every inference call by
temporarily replacing
requests.Session.merge_environment_settingsprocess-wide.This also changes unrelated sessions while the request is in flight.
This change uses Requests’ normal certificate verification by default and passes
the optional
verifyvalue directly to this agent’s request. A CA bundle pathsupports private certificate authorities. Existing self-signed deployments can
explicitly select
verify: false; that choice remains scoped to the agent’srequest and retains Requests’ warning. The config documentation explains this
migration.
Validation on
d1e4a10db08c87075c78972e48ecc182be03e2d5:python -m unittest discover -s tests -v: 3 passed. A temporary local HTTPSserver verifies default rejection of an untrusted certificate, acceptance of an
explicit CA bundle, and isolation of an explicit opt-out from other sessions.
untrusted request succeeds.
python scripts/validate_lite_configs.py: passed, matching repository CI.controlled local HTTP responses.
The tests generate and remove their own short-lived certificate and key. No
hosted model or full benchmark result is claimed. OpenAI Codex assisted with this
change and validation.