[ryanbarlow97]

Correct seven findings from #273 in the website's technical docs. Three findings depend on configuration that is absent from the current source checkouts and remain unverified. Changes are limited to documentation.

1. Fixed — ledger deltas (comment): backend/src/api/ledger_routes.py::_faction_block copies absolute stock values into series; clients calculate observed changes. Preserve the distinction between projected flows and observed stock changes.
2. Fixed — identifier rules (comment): backend/src/skins/naming.py::assert_slug accepts a trailing underscore and separately rejects doubled underscores. Document both checks and distinguish validation from generated IDs, which trim trailing underscores.
3. Fixed — ArmourShop acknowledgement order (comment): ArmourShop's DeferredIaReloadService dispatches iareload, then delayed iazip, and acknowledges after ItemsAdderPackCompressedEvent. Align the sequence and deferred-reload steps with that source.
4. Fixed — control-socket GID (comment): pin group creation to GID 996 to match the host Compose override documented in docs/DEPLOY.md; backend/src/servers/host.py::socket_group resolves the existing group's GID, and the service selects tfmc-control by name. Host overrides are administrator-managed and were not inspected on a server.
5. Fixed — workstation API binding (comment): bind the local Uvicorn example to loopback. The frontend uses NEXT_PUBLIC_API_URL, and backend/server.py allows the local frontend origins.
6. Skipped — Research rune-source mapping (comment): current Research source resolves configurable t.* templates, but neither it nor the available ServerAssets snapshot contains Research/templates/runestones.yml or the Staff Runestone project, so the two specific rune outputs cannot be verified.
7. Skipped — lore-thesis EXP (comment): Research completion emits a configurable result item and an event; the Codex category/reward and codex_research.yml configurations needed to verify the pages 2–3 / 100 EXP claim are absent from current checkouts.
8. Skipped — world-boss tickets (comment): current checkouts contain neither x_world_bosses.yml nor the MMOItems boss-ticket definitions, so the claimed material/model-data mismatch cannot be verified against current configuration.
9. Fixed — Mount Whistle table (review nitpick): restore the third cell and replace the attribution guess with current TFMCCore source: WhistleListener highlights animals on right-click, with a default 64-block radius in WhistleConfig.
10. Fixed — local evidence path (review nitpick): remove the workstation profile prefix from the Archer evidence identifiers while preserving the cited snapshot filenames and ranges. The available MythicMobs tfmc_skills_mobs.yml corroborates the decoy copy behavior; the old class-skill snapshot is unavailable, so its behavior claims were not revised.

Validation: all 350 relative links and anchors across 55 Markdown pages resolve, including reference links and linked images, using the workspace documentation checker's parser. All 15 local JSON schema references resolve. The checker's 5 unit tests, direct checks of the API identifier validator, and git diff --check pass. The two new TFMCCore source links were checked through the GitHub API.

Prepared by an AI agent.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 41 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 14702594-0e3c-4a99-af52-b81cc6e15ed1

📥 Commits

Reviewing files that changed from the base of the PR and between 1df0d1c and d53b972.

📒 Files selected for processing: 7

• docs/docs/assets/map-export-schema.json
• docs/docs/cosmetics/naming.md
• docs/docs/integrations/armourshop.md
• docs/docs/integrations/servers.md
• docs/docs/ops/local-dev.md
• docs/docs/wiki-research/a2-gems-dowsing-archaeo.md
• docs/docs/wiki-research/class-skill-descriptions.md

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}