Stage 6b: estates (death guild, vehicles, replay guard, upkeep pause)

[ryanbarlow97]

Stage 6b (estates and wills) for SimpleFactions 4.2.0, on the TLibs 2.6.0 estate API. SimpleFactions answers which guild a character died in, hands dead owners' personal vehicles to the estate recipient, stops its death journal from acting on a revived or re-dead character, and pauses upkeep while vehicles wait for an estate. Design: stage 6b v2.3, rules E10 and E12, the SimpleFactions participant section and review items M1, M5, M11, N2, N3 and P2–P4.

Death realm. Death capture records a new optional journal field, lockGuildRealm: the incarnation of the death guild's realm's ruling guild, taken from the same ungated lookup and civil-war mapping as lockGuildIncarnation (a moved rebel follows its origin guild in the host realm). Journal validation accepts it and closedBy.

Replay guard. Before an incomplete journal replays, the character is read. If it is still DEAD with that death ID, the journal replays as before. If it is ALIVE, or dead with another death ID, the journal is closed: remaining steps are marked done unapplied, complete=true and closedBy: revive|redeath. Claims whose cleanup step never applied are cancelled in the same durable write by setting paid = cents, because their wage bucket and dividend eligibility were never cleared, so nothing is paid twice. An unreadable or MISSING character is skipped for now (staff decide MISSING characters). Older jars read a closed journal as complete and its cancelled claims as paid, and their Gson ignores the new fields. A succession step never displaces a living seat holder but still fills a blank seat.

EstateFallback, registered once factions start (before SimpleFactionsReadyEvent):

• deathGuild(character, deathId): UNAVAILABLE while SimpleFactions is not ready or a referenced death has no journal yet; NONE for a guildless death; otherwise the death guild with its live state, current leader (Guild.getLeader(), the realm's for a ruling guild) and the realm recorded at death. For older journals the realm comes from the one stored rights plan that lists the guild; snapshot() is never re-run.
• guild(incarnation) and guildByName(name): UNAVAILABLE, GONE, or LIVE with the treasury guild:<incarnation> and the realm as its ruling guild's incarnation. guildByName also accepts an incarnation; a name two guilds share answers UNAVAILABLE.
• No lookup creates a guild. The reference scan behind UNAVAILABLE no longer creates a realm's main guild either.

Vehicles participant simplefactions-vehicles, registered at the end of the vehicle stage. It finds vehicles by personal payer row or VehicleFramework owner, writes vehicles/estates/<deathId>.json durably before the first change, then moves the payer row (payments.personal), the owner (VehicleOwnerWrites.write(HANDOVER)) and the last owner (fee store's durable save) as separate durable steps. The estate gate checks a known type, not faction-owned, payments ready and not blocked, and not VehicleQuarantine.held. There is no fee, slot or battle-lock check. Replay follows the observed row and tag:

Observed	Action
tag neither from nor to	close as superseded; never rewritten
row not to	redo the row, whatever the tag says
row to, tag from	redo the owner change
row to, tag to, before lastOwner	record the last owner
row to, tag to, lastOwner	done

NOT_FOUND or an unreadable vehicle is BLOCKED after three checks at least an hour apart, and the dead owner's row is not put back. A blocked vehicle stays blocked until the estate provider calls again (staff /estate retry), which reads it once more. An entry planned for another recipient is BLOCKED rather than reported moved. Waiting or frozen property answers DONE even while the vehicle stage is down. Other owner-change failures put the previous row back and retry. DONE carries the count and every moved vehicle ID. A boot and hourly reconcile over Estates.decided() catches vehicles that appear later, such as a build finishing for the dead payer; failures are caught per estate.

Upkeep pause. While the payer is dead and its latest estate is OPEN, HELD or DECIDED, settlement marks no new unpaid day and the hourly upkeep deals no damage. An unpaid marker set before the death stays.

Capability gate. EstateBridge probes the TLibs 2.6.0 classes once. Only EstateCalls, GuildEstateFallback and the participant touch them, and every call is caught, so on TLibs 2.5.0 SimpleFactions enables and simply takes no part in estates. No estate error can reach failFinancialState.

Docs: TF-Minecraft/Docs#219

Gate: tfmc-mvn -o -B clean verify: 7,985 tests, 0 failures, 100% line coverage. Tests cover crash and replay at each vehicle step, claim cancellation without double payment, old-jar journal compatibility, the civil-war realm, and the absent and UNAVAILABLE paths. CI may 404 on the unreleased TLibs 2.6.0.

🤖 Generated with Claude Code

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}