Skip to content

Filler tier for /ac give equipment; halve animal toughness - #48

Merged
XxFran10xX merged 2 commits into
mainfrom
feat/give-filler-tier
Oct 27, 2026
Merged

XxFran10xX merged 2 commits into
mainfrom
feat/give-filler-tier

Conversation

@XxFran10xX

Copy link
Copy Markdown
Contributor

Summary

Command: /ac give equipment takes an optional sixth argument, a filler tier:

/ac give equipment <recipe> <ingredient.id|alloy.id> [player] [quality 0-100] [filler tier]

Each non-main slot gets the highest-tier ingredient of its type at or below that tier, or the lowest tier if they are all above it. Without the argument the command still uses the lowest tier, so existing commands and kits behave the same. Tutorial's PvP kits will use 4 to give gear made with legendary animal materials.

Default config: animal materials and armour toughness, matching the live change.

  • Feather, leather and wool toughness per piece: rare 0.5 → 0.25, epic 0.75 → 0.375, legendary 1.0 → 0.5.
  • Template toughness bases: Light 0.5 → none, Medium 1.0 → 0.5, Heavy 2.0 → 1.5, Infantry 0.5 → none. Infantry now takes toughness from its feathers (armor_toughness added to its stats: list).

Mythril sets by animal tier (common / rare / epic / legendary):

Set Common Rare Epic Legendary
Light 8/0 8/1 8/1.5 8/2
Medium 12/2 12/3 12/3.5 12/4
Heavy 16/6 16/7 16/7.5 16/8
Infantry / Mage 12/0 12/1 12/1.5 12/2

Before this, the #46 values plus legendary material gave 8/6, 12/8 and 16/12. Epic shows 0.38 per piece because stats round to 2 decimals.

Testing

  • EquipmentGiveCommandTest covers tier 4 picking the highest tier, tier 1 picking the lowest, falling back when every ingredient is above the tier, invalid tiers, the extra-argument usage error and tab completion.
  • Locally, everything except 4 station-database tests passes. Those 4 fail on Windows because of file locks and permissions; CI on Linux runs the full suite.

🤖 Generated with Claude Code

XxFran10xX and others added 2 commits October 27, 2026 16:31
/ac give equipment <recipe> <material> [player] [quality] [filler tier]
fills each non-main slot with the highest-tier ingredient of that type at
or below the given tier (lowest tier when all are above it). Without the
argument it still uses the lowest tier, so existing commands are unchanged.
Lets kits hand out gear made with legendary animal materials.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Animal materials (feather, leather, wool) now add 0.25 / 0.375 / 0.5
toughness per piece at rare / epic / legendary. Template toughness bases:
light none, medium 0.5, heavy 1.5, infantry none and it now takes
toughness from its feathers. Mythril with legendary animal materials gives
the intended sets: light 8/2, medium 12/4, heavy 16/8, infantry 12/2.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@XxFran10xX

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4388d4c9-6818-4999-89de-384dbea8a9ec
Commits

Reviewing files that changed from the base of the PR and between 5145934 and 06ac985.

Files selected for processing: 4
  • src/main/java/net/tfminecraft/advancedcrafting/managers/EquipmentGiveCommand.java
  • src/main/resources/ingredients.yml
  • src/main/resources/stats.yml
  • src/test/java/net/tfminecraft/advancedcrafting/EquipmentGiveCommandTest.java

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

  • New Features
    • The equipment-giving command now accepts an optional filler tier, allowing you to choose compatible filler ingredients up to the specified tier. Invalid tier values are rejected, and the command suggests tiers 1–4 during tab completion.
  • Gameplay Changes
    • Armor toughness has been reduced for rare, epic and legendary leather, feather and wool materials, and for medium and heavy armor.
    • Light and infantry armor no longer receive base armor toughness.

The equipment give command now accepts an optional filler tier and selects a compatible ingredient based on it. The configuration also changes toughness values for selected ingredients and armour stats.

Changes: Filler Tier Selection

Layer / File(s) Summary
Command arguments, selection, and validation
src/main/java/net/tfminecraft/advancedcrafting/managers/EquipmentGiveCommand.java, src/test/java/net/tfminecraft/advancedcrafting/EquipmentGiveCommandTest.java
The command accepts and validates an optional seventh argument for filler tier. It selects a filler based on the tier, offers tier suggestions, and retains lowest-tier selection when no tier is supplied. Tests cover validation, completion, and provenance inputs.

Armour Toughness Values

Layer / File(s) Summary
Ingredient and armour stat adjustments
src/main/resources/ingredients.yml, src/main/resources/stats.yml
The configuration reduces toughness values for rare, epic, and legendary leather, feather, and wool. It removes base toughness values from light and infantry armour and lowers the base values for medium and heavy armour.

Priority: Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Merge Risk: Minimal · up to 06ac9

No concrete current-head defect is established; the change is suitable for merge with normal CI validation.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:M 30-99 effective changed lines (tests excluded in mixed PRs). label Oct 27, 2026
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@XxFran10xX
XxFran10xX merged commit 7dbd281 into main Oct 27, 2026
3 checks passed
@XxFran10xX
XxFran10xX deleted the feat/give-filler-tier branch October 27, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 effective changed lines (tests excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant